correct memory leak of struct ly_in * objects
#129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`data_load()` returns a reference to `struct ly_in *` which must be free'd by `lys_in_free()`. This is done in one of three locations. This corrects this oversight. This was found during unit tests of SONiC during porting to libyang3 from libyang 1.0.73. Signed-off-by: Brad House <brad@brad-house.com>
Contributor
Author
|
CI failure is likely due to ubuntu-latest which is used by lint being migrated to ubuntu-24.04 from ubuntu 22.04. I might stack another commit on top of this to test that. |
Contributor
Author
|
nope, still failed. No idea, that's not a file I've touched and the import statement it is failing on looks valid. |
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 7, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 7, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 7, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 8, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 8, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 9, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 9, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 9, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 11, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 11, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 11, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 12, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 13, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 16, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 16, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 16, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 16, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 16, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 16, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 16, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 17, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 20, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 20, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 21, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 25, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 25, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 25, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 25, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Feb 28, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 1, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 1, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 3, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 4, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 6, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 8, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 11, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Mar 12, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 3, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 3, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 20, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 22, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 23, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Apr 24, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jun 13, 2025
Sent upstream here: CESNET/libyang-python#129
bradh352
added a commit
to bradh352/sonic-buildimage
that referenced
this pull request
Jun 13, 2025
Sent upstream here: CESNET/libyang-python#129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data_load()returns a reference tostruct ly_in *which must be free'd bylys_in_free(). This is done in one of three locations. This corrects this oversight.This was found during unit tests of SONiC during porting to libyang3 from libyang 1.0.73.
Signed-off-by: Brad House (@bradh352)