(1.21.1) Fix placing vertical slabs in water crashing the game #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… water We weren't unsetting waterlogged on the state we were using to index into the baked model map, so it didn't match and ended up dereferencing a null pointer. From what I can see this fixes both the initial crash and the inability to load back into the world afterwards.
…xed slab is broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised in #311, placing a vertical slab in water will crash the game because we cannot find the model to render for the 'waterlogged' state.
The fixes were created in #318 and #315 for 1.21.1 but I want to get these merged in as soon as possible so I've took those PRs and merged them with the changes I requested in this PR.