Skip to content

Return imgCIF to checking workflow #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesrhester merged 5 commits into from
Sep 23, 2025
Merged

Return imgCIF to checking workflow #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e37549d
Add imgCIF to test dictionaries
jamesrhester Sep 17, 2025
cfe34c8
Fix imgCIF head category name
jamesrhester Sep 17, 2025
7e43d30
Fix errors related to imgCIF import
jamesrhester Sep 17, 2025
751a731
Fix dates
jamesrhester Sep 17, 2025
3d48877
Change dictionary update date
vaitkus Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,12 @@ jobs:
repository: COMCIFS/MultiBlock_Dictionary
path: cif-dictionaries/MultiBlock_Dictionary

- name: Checkout DDLm imgCIF dictionary
uses: actions/checkout@v4
with:
repository: COMCIFS/imgCIF
path: cif-dictionaries/imgCIF

- name: check_ddlm
uses: COMCIFS/dictionary_check_action@main
id: ddlm_check
15 changes: 9 additions & 6 deletions cif_pow.dic
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ data_CIF_POW
_dictionary.title CIF_POW
_dictionary.class Instance
_dictionary.version 2.5.0
_dictionary.date 2025-08-04
_dictionary.date 2025-09-23
_dictionary.uri
https://raw.githubusercontent.com/COMCIFS/Powder_Dictionary/master/cif_pow.dic
_dictionary.ddl_conformance 4.2.0
Expand All @@ -32,7 +32,7 @@ save_PD_GROUP
_definition.id PD_GROUP
_definition.scope Category
_definition.class Head
_definition.update 2024-12-13
_definition.update 2025-09-23
_description.text
;
Groups all of the categories of definitions in the powder
Expand All @@ -44,7 +44,7 @@ save_PD_GROUP
_import.get
[
{
'dupl':Ignore 'file':cif_img.dic 'mode':Full 'save':HEAD
'dupl':Ignore 'file':cif_img.dic 'mode':Full 'save':CIF_IMG_HEAD
}
{
'dupl':Ignore 'file':multi_block_core.dic 'mode':Full
Expand Down Expand Up @@ -6908,7 +6908,7 @@ save_pd_diffractogram.scan_id
_type.purpose Link
_type.source Assigned
_type.container Single
_type.contents Text
_type.contents Word

save_

Expand Down Expand Up @@ -8730,7 +8730,7 @@ save_pd_instr_detector.diffrn_detector_id
_type.purpose Link
_type.source Related
_type.container Single
_type.contents Text
_type.contents Word

save_

Expand Down Expand Up @@ -14441,7 +14441,7 @@ save_

Deprecated _pd_refln.wavelength_id after consultation with PDDMG.
;
2.5.0 2025-08-04
2.5.0 2025-09-23
;
## Retain above version number and increment date until final
## release
Expand Down Expand Up @@ -14683,4 +14683,7 @@ save_
and _pd_pref_orient_spherical_harmonics.geom to _pd_pref_orient.geom.

Added _structure.phase_id.

Fixed imgCIF import head category name. Corrected types of
links to _diffrn_scan.id and _diffrn_detector.id.
;