Extract common code into src/common #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedlocc
requested changes
Feb 23, 2025
Member
dedlocc
left a comment
dedlocc
left a comment
There was a problem hiding this comment.
не вижу смысла переусложнять и разбивать на 100500 файлов и обмазываться макросами
если уж на то пошло, я бы просто сделал условный common.asm, в который продублировал из add.asm всё, кроме собственно самого сложения и _start, и добавил его pre-include'ом (https://www.nasm.us/doc/nasmdoc2.html#section-2.1.19)
clzll
force-pushed
the
feature/extract_common_code
branch
from
f3aa198 to
a07a27e
Compare
dedlocc
requested changes
Feb 23, 2025
Member
dedlocc
left a comment
dedlocc
left a comment
There was a problem hiding this comment.
- Давай добавим в README пояснение того, что тут происходит. Может быть неочевидно, откуда функции берутся.
- В исходных
sub.asmиmul.asmвозможно всё же стоило бы оставить копиюadd_long_long(пусть даже с другим названием), так проще смотреть дифф, в частности дляsub
clzll
force-pushed
the
feature/extract_common_code
branch
from
a07a27e to
89f9608
Compare
dedlocc
reviewed
Feb 23, 2025
Member
dedlocc
left a comment
dedlocc
left a comment
There was a problem hiding this comment.
Спасибо. Мёрджить в этом году уже не будем, чтоб не создавать конфликты в случае, если будут обновления, но в следующем может быть полезно.
clzll
force-pushed
the
feature/extract_common_code
branch
from
b2c22a6 to
89f9608
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About 300 lines of code are the same in
add.asm,sub.asmandmul.asm, thus it makes sense to move that code out.