-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add rover update #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a Docker image update feature to the web UI, allowing users to pull the latest versions of three system images (rover, web-ui, and container-launcher) directly from the interface. It integrates react-hot-toast for real-time feedback and makes the SetResetPanel component more flexible with customizable button labels.
Key Changes:
- Added a new "Update system" button that triggers parallel Docker image pulls with toast notifications for progress and status
- Made
SetResetPanelbutton labels configurable via new optional propsbutton1Nameandbutton2Name - Integrated
react-hot-toastlibrary (v2.6.0) for user feedback with loading, success, and error states
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/SetResetPanel.tsx | Added optional props for customizable button labels with default values |
| src/components/ContainerList.tsx | Replaced reset functionality with Docker image pull workflow, added toast notifications and confirmation dialog |
| src/app/launch/page.tsx | Added Toaster component to display toast notifications |
| package.json | Added react-hot-toast dependency (^2.6.0) |
| package-lock.json | Added react-hot-toast and goober dependency entries with resolved versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
04f5450 to
46ae8fb
Compare
| "integrity": "sha512-b/ZCF6amfAUb7dJM/MxRs7AetQEahYzJ8PtgfrmEdtw6uyGOr+ZSGtgjFm6mfsBkxJ4d2W7kg+Nlqzqvn3Bc0w==", | ||
| "license": "MIT" | ||
| }, | ||
| "node_modules/goober": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goober
This pull request introduces a user-friendly way to update Docker images from the UI, adds toast notifications for feedback, and improves button labeling for clarity. The most important changes are grouped below.
Feature Addition: Docker Image Update Workflow
SetResetPanelinContainerList.tsxthat triggers pulling the latest versions of three Docker images (cprtsoftware/rover:amd64,cprtsoftware/web-ui:latest, andcprtsoftware/container-launcher:latest) from the backend. The process provides confirmation and feedback to the user. [1] [2]User Feedback Improvements
react-hot-toastto display real-time notifications for each Docker image pull operation, including loading, success, and error states, as well as a final "All pulls finished" message. [1] [2] [3] [4]UI/UX Enhancements
SetResetPanelto support customizable button names via new propsbutton1Nameandbutton2Name, allowing for more descriptive labels such as "Update system" instead of the generic "Reset". [1] [2] [3]