Big update to Shandalar Old Border by RemusLord #9212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
How does this relate to #8859? |
Contributor
Author
|
#8859 was the last major update, this is the next one. Shenshinoman created the planes and was helping me post PRs for the old-border adventure, since I didn't know how to do that :) This is my first PR, but I'll be posting updates to the old-border mod directly henceforth. |
Contributor
|
(Reopening and closing duplicate #9217) |
Contributor
Author
|
Thanks for much. Sorry for the inconvenience. |
Contributor
|
No trouble. Be sure to mark it as ready for review once you're done making changes and testing it. @shenshinoman Should #8859 be closed, superseded by this? |
tool4ever
reviewed
Nov 20, 2025
Contributor
Author
|
Ok I think I got it. Correct? Thanks for all your support
…On Thu, 20 Nov 2025 at 20:37, Jetz72 ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On forge-gui/res/adventure/Shandalar Old Border.zip
<#9212 (comment)>:
Looks good. There are a couple other .gitignore entries in the PR that
look exclusive to your development setup. You might want to clean those up
as well.
—
Reply to this email directly, view it on GitHub
<#9212 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANP6R22HAYLWX5NONXFVZTT35YKAZAVCNFSM6AAAAACMVEHRBKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTIOBZGYZDAOBXGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
- Add explicit edition codes to item cards (Metallic Sliver|TMP, Thunder Wall|LEG, Disrupting Scepter|LEA, etc.) - Replace Hivestone with Metallic Sliver|TMP (Hivestone is modern) - Fix cave_snake.tmx lands to use 6ED editions - Update hellion.dck to use Mountain|6ED - Change Devil shop to Imp shop (Devils not old border legal) - Add initial restrictedEditions config for 8ED, P8ED, MRD 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Delete cave maps featuring creatures that don't exist in old border: - Dinosaurs, Eldrazi, Kavu, Mimics - Kobold multi-level caves - Other maps with irreplaceable modern content These maps use the common directory versions which will be filtered by the card legality system. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Replace modern cards with old border alternatives across all existing maps: - Replace illegal startBattleWithCard effects with pre-Scourge cards - Remove boss abilities (startBattleWithCardInCommandZone) - Fix card references to use oldest legal printings Affects aerie, cave, catlair, djinnpalace, emrakul, evilgrove, factory, fort, garruk, graveyard, grolnok, grove, jacetower, lavaforge, magetower, monastery, nahiri, skep, skullcave, tibalt, vampirecastle, zedruu, and main story maps.
Copy additional maps from common directory with illegal card fixes: - barbariancamp, catlair (leonin/tiger), demontower - djinnpalace, emrakul fortress, evilgrove expansion - factory, fort (blue/colorless), garruk forest maps - graveyard/crypt variants, grove expansion - jacetower/portal maps, library of varsil - merfolkpool, monastery, nahiri caves, naktamun - skullcave, temple maps All maps updated to use pre-Scourge (2003) legal cards only.
- enemies.json: Update boss rewards to use oldest legal printings - items.json: Fix card references to old border editions - points_of_interest.json: Update map references to local copies
Copy maps from common and fix illegal modern cards: cave_kavu.tmx: - Coveted Jewel (C18) → Horn of Greed|STH - Add edition codes: Kavu Lair|INV, Jungle Barrier|APC, Coastal Drake|APC cave_multilevel/cave_16BR3U.tmx: - Bontu's Monument (AKH) → Subversion|ULG
Copy maps from common and fix illegal modern cards: cave_bigzombie.tmx: - Dreadhorde Invasion (WAR) → Sarcomancy|TMP cave_cerodon.tmx: - Desert of the Fervent (HOU) → Shivan Gorge|USG
- Rename devil.json deck to imp.json with Imp subtype - Update enemies.json Devil entry to Imp - Update red biome spawn list - Update all map references from Devil to Imp
- Spare Dagger: replaced with Rod of Ruin|LEA - Dark Boots: Clattering Augur → Drudge Skeletons|LEA - Slimefoot drop: changed from Gooey Shoes to Thallid Farming Tools
- white_castle.tmx: Dwarf Warlord → Dwarf Lord, Sun Giant → Sun Titan - green_castle.tmx: Forest Giant → Forest Titan - blue_castle.tmx: Brain Mole → Mill Mole, Merfolk Fighter → Merfolk King Castle NPC versions have individual starting cards and proper decklists.
Replace illegal modern set editions (NPH, ONE, MOM) with Urza's block editions (USG, ULG, UDS, INV, APC) in all 5 Phyrexian dungeon booster rewards. This fixes empty treasure chests that had no legal cards in pool.
- Mishra: Added Workshop, Groundbreaker, Ankh of Mishra, Dragon Engine - Tsabo Tavoc: Fixed wrong cards (was angelic) to Tsabo's Web/Assassin, zombies - Ashnod: Added Altar, Battle Gear, Cylix, Transmogrant, Walkers - Yawgmoth: Complete effect with Bargain, Altar, Eye, Walkers, Battleflies - Jaya Ballard: Fixed to Mountains, Blood Moon, Fire Elemental, Sulfuric Vapors
Replace Serra's Liturgy|USG with Serra's Blessing|WTH for balance.
Balance adjustments to emrakul, lathliss, jace, zedruubis, and scarecrowcaptain decks.
The EnemyData class does not support effect fields - effects must be defined in map files. Removed invalid effect blocks from 6 bosses that were causing SerializationException on map load: - Mishra - Tsabo Tavoc - Ashnod - Gix - Yawgmoth - Jaya Ballard
- Gix: Updated startBattleWithCard to include 2x Priest of Gix, Tainted Aether, Oppression, Bereavement - Jaya Ballard (Easy): Added missing effect with 4x Mountain, Blood Moon, Fire Elemental, Wall of Diffusion, Book of Rass, Sulfuric Vapors
- cave_dino: Move Triassic Egg chest to reachable position (y=155) - cave_spider: Remove Black color filter so Spider creatures can be found - cave_treasure: Add Shoes of Sorrow item reward
- Merge duplicate dungeonEffect properties into single combined effect - Remove ignoreDungeonEffect from Phoenix and Mimic enemies - Add Ancient Tomb to the dungeon-wide effect list
Add -1 lifeModifier to balance the Grizzly Bears effect
Introduces 11 new legendary wizard enemies themed around dual lands and Invasion dragons: - 5 dual-land mages (Savannah, Taiga, Tundra, Badlands, Underground Sea) - 5 dragon-themed mages (Treva, Rith, Dromar, Crosis, Darigaaz) - 1 five-color Domain Keeper of Cromat Each enemy has a themed deck and spawns in appropriate biomes based on their color identity. Also adds cromat_angel sprite and reduces Diamond Kaleidoscope drop rate from 100% to 20%.
Corrects card references using malformed |SET|SET format to proper |SET format in startBattleWithCard effects across multiple maps.
Places specific legendary creatures as treasure rewards throughout various dungeons: - Barbarian Camp: Stangg, Johan - Djinn Palace: Hanna, Ship's Navigator - Graveyard Crypt: Dakkon Blackblade - Mage Tower: Tsabo Tavoc, Nebuchadnezzar - Maze: Bartel Runeaxe - Snow Abbey: Asmira Holy Avenger, Ragnar - Vampire Castle: Gwendlyn Di Corci
Copy remaining map files from common/maps/map to Shandalar Old Border/maps/map to ensure all maps are available locally. This includes: - Cave multilevel maps (cave_16B, cave_16BR*, cave_16BL*, cave_18C/E/N/W, etc.) - Secondary floor maps (cave_kobold_floor2, cave_zombie_floor2) - Template and tileset files - Additional dungeon maps Tileset and object template paths updated to correctly reference common/maps/tileset/ and common/maps/obj/ from the local map locations.
Update teleport paths that used incomplete formats like "maps/map/X.tmx" to the correct local mod format "../Shandalar Old Border/maps/map/X.tmx". This fixes map navigation in garruk forest and jacetower portal areas where teleports were pointing to invalid paths.
Updates items to use unique sprites instead of generic placeholders: - Shield of the Ages: custom shield sprite - Belbe's Armor: custom armor sprite - Life Chisel: chisel sprite - Feverbringer's Cloak: cloak sprite - Splicer's Charm: Phyrexian Splicer sprite Adds corresponding sprite atlas entries mapping iconNames to coordinates.
Lavaforge: Swap battle cards between Fire Giant (now Thran Dynamo) and Mindclaw Shaman (now enchantment suite) to better match enemy themes. Teferi: Replace Teferi's Realm with Teferi's Honor Guard for a more balanced encounter while keeping the Teferi-themed card selection.
Correct the number of ../ levels in source and template paths to properly reach common/maps/tileset/ and common/maps/obj/ from local map locations. Depth 1 maps need 6 levels, depth 2 maps need 7 levels.
Contributor
Author
|
Is the review still pending? Sorry to ask, I'm not familiar with the process. Thanks very much :) |
Contributor
|
Looks good to me, though I admit it's very difficult to look through the entire submission ^^; |
Contributor
Author
|
I know, it’s a lot. It’s an accumulation of work over the last months.
Honestly, it’s in a much more functional state than the current old border
build :)
Been collecting bug reports from a couple testers over the last weeks and
we’re pretty much bug free now as far as I see it. There will be stuff that
comes up still, but the testers seem really happy with it so far.
…On Thu, Nov 27, 2025 at 20:42 Agetian ***@***.***> wrote:
*Agetian* left a comment (Card-Forge/forge#9212)
<#9212 (comment)>
Looks good to me, though I admit it's very difficult to look through the
entire submission ^^;
Seems like good changes and improvements!
—
Reply to this email directly, view it on GitHub
<#9212 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANP6R24HZMNVGQK3DJ4LD4L365HYXAVCNFSM6AAAAACMVEHRBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKOBXGEZDGOJVHE>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Agetian
approved these changes
Nov 27, 2025
Contributor
Author
|
Thanks for the review. Really appreciate it. I clicked update branch. Was that right? |
Contributor
Author
|
Thanks a lot!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old Border Mod Changelog
Card Pool & Edition Filtering
Boss & Enemy Decks
Boss Rewards & Equipment
Map Fixes
Items & Sprites