-
Notifications
You must be signed in to change notification settings - Fork 807
Add adventure world-specific battle and menu background support #9332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add adventure world-specific battle and menu background support #9332
Conversation
Jetz72
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the background correctly update if you change planes without restarting the application? I think load is only invoked when the texture first appears, and I don't know if it's unloaded after that point.
97de74a to
8eba775
Compare
It doesn't automatically update without restarting. However, changing planes prompts the user to restart anyways. |
|
I'd like to think we'll eventually get rid of the need to restart to change planes. I don't like adding to the list of problems that will need to be identified and solved in order to achieve that. Could just use a static method to clear out all the adventure background textures and invoke it when switching planes. (Which would be another use case for that EnumSet just sayin' 😝) |
8eba775 to
731c474
Compare
Allow adventure worlds to provide custom battle backgrounds by placing files in their skin/ directory (e.g., skin/adv_bg_swamp.jpg). The texture loading order is: 1. Adventure world skin directory (e.g., Shandalar Old Border/skin/) 2. Common adventure skin directory (common/skin/) 3. Default skin directory (fallback) This enables adventure creators to customize biome-specific battle backgrounds without modifying the default skin.
731c474 to
275945f
Compare
|
Great point. Added |
skin/directory, using the same pattern thatSoundSystemuses to allow custom music.Shandalar Old Border/skin/adv_bg_swamp.jpg)common/skin/)