Skip to content

Add Glfw3 windowing #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FireController1847 merged 15 commits into from
Nov 9, 2025
Merged

Add Glfw3 windowing #4

FireController1847 merged 15 commits into from
Nov 9, 2025

Conversation

@FireController1847
Copy link
Member

@FireController1847 FireController1847 commented Nov 3, 2025

📑 Summary

Primary changes were the introduction of the Crystal namespaces and the associated interfaces and supporting Glfw3 implementation for windowing.

⚒️ Changes

Caution

Accurately describing the changes made in this PR will greatly improve the speed at which we can review your PR. Semantic Versioning can be helpful in determining the scope of your change, and will help in determining the appropriate version number, merge location, and timing of the integration of your change.

➕ Additions

Added the following projects to the repository:

  • Modules/Crystal/CatalystUI.Modules.Crystal.Core
  • Modules/Crystal/CatalystUI.Modules.Crystal.Glfw3

Additionally, changes from about four months ago in the original CatalystUI development project have now been migrated into the latest version, including a refactored implementation of GlfwDisplay and GlfwWindow.

✖️ Modifications

All changes are noted in the individual commits.

➖ Removals

💬 Review

Important

Accurately listing key items for review will help us review your PR more quickly. Please include large changes, breaking changes, and any other changes that may require special attention.

Reviewers will check off items in the list as they are reviewed, in addition to the normal GitHub review process. They may request changes if any items are not adequately addressed or add additional items as necessary.

  • Ensure all modifications made are consistent with previous CatalystUI iterations.
  • Ensure all classes follow the CatalystUI model and design.
  • Basic spelling and grammar check across the board in all comments please.

CatalystUI Framework for .NET Core
Copyright (c) 2025 CatalystUI LLC. All rights reserved.

@FireController1847
Add the Crystal project
18a671f 
* Added the Crystal module to the solution.
* Imported varying interfaces for visual windows and displays from previous project iterations.
* No additional changes were made.
@FireController1847
Add basic Glfw3 display implementarion
bd897d4 
* Added the previous works of the Glfw3 implementation to the Crystal module.
* Resolved missing import in Core/CatalystApp.cs
* Resolved missing import in Tooling/Analyzers/CachedDelegateGenerator.cs
@FireController1847
Add Glfw3 window implementation
b85dfe1 
* Added the previous works of the Glfw3 implementation to the Crystal module.
@FireController1847
Add Catalyst.Mathematics.Color
1e6f3ef 
* Added Color128, Color32, & IColor interface to the Mathematics project
@FireController1847
Add renderer interfaces to Catalyst.Modules.Crystal.Core
2b2697b 
* Added the new IRenderer interface from 4 month-old CatalystUI's `dev`branch
* Created a new concept "IRenderLayer" and "IRenderTarget."
* Removed "IWindowDomain" and swapped it to be on the "IMultisensoryDomain."
@FireController1847
Modify the IDataConnector and INativeConnector generic requirements
34a79c9 
* Updated the data and native connectors to allow for connecting to various layers, rather than being restricted to their immediate neighbors.
@FireController1847
Minor comment improvements
a77174e
@FireController1847
Generalized code cleanup
b312e08
@FireController1847
Optimize imports
cf6d6e1
@FireController1847
Significant refactoring to GlfwWindow
4bb9e36 
* Resolved prefix not being appended in the SerilogDebugContext
* Add new variable to IWindow for a ThreadDelegateDispatcher
* Removed hard requirement for the windowing API to be run on the main thread (still recommended though).
* Resolved some debugging logs unnecessarily emitting the full namespace of the associated class.
@FireController1847 FireController1847 self-assigned this Nov 3, 2025
Copilot AI review requested due to automatic review settings November 3, 2025 02:54
@FireController1847 FireController1847 added ACT: Review A pull request which is currently under review. CAT: Feature Request A category of issues which are feature requests. P4: High Priority A bug or feature request that needs to be resolved relatively soon. labels Nov 3, 2025
Copilot AI reviewed Nov 3, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the Crystal module for CatalystUI, implementing windowing functionality using GLFW3, along with supporting infrastructure for display management, renderers, and native platform integration.

  • Adds complete windowing API with IWindow, IDisplay, and IWindowLayer interfaces
  • Implements GLFW3-based windowing with GlfwWindow, GlfwDisplay, and native connectors for Windows and macOS
  • Includes renderer interfaces (IRenderer, IRenderTarget, IRenderLayer) for graphics rendering
  • Refactors core threading and mathematics components to support windowing operations

Reviewed Changes

Copilot reviewed 49 out of 49 changed files in this pull request and generated 16 comments.

Show a summary per file
File Description
CatalystUI.Modules.Crystal.Core Core interfaces and types for windowing, display, and rendering systems
CatalystUI.Modules.Crystal.Glfw3 GLFW3 implementation of windowing layer with native platform connectors
CachedDelegateGenerator.cs Adds System namespace import for generated code
ThreadDelegateDispatcher.cs Refactors to expose Thread and ThreadId as public properties
Angle.cs Refactors internal field to public property for better encapsulation
Color classes Adds IColor interface and Color32/Color128 implementations
Various core files Minor import reordering and code style improvements

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI mentioned this pull request Nov 3, 2025
Closed
@CatalystUI CatalystUI deleted a comment from Copilot AI Nov 3, 2025
@FireController1847
Resolve copilot review suggestions
7f3353c
@FireController1847
Resolve thread delegation issues with Glfw
626ba93 
* Resolved INativeApi in the core not giving APIs an opportunity to initialize on a different thread.
* Updated IWindowLayer to allow passing a different dispatcher.
ThisIsBrady
ThisIsBrady requested changes Nov 3, 2025
View reviewed changes
RealCrazeOfficial
RealCrazeOfficial requested changes Nov 9, 2025
View reviewed changes
Copy link
Contributor

@RealCrazeOfficial RealCrazeOfficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon review, I found 15 grammatical changes in in-line comments.

@FireController1847 @RealCrazeOfficial
Apply suggestions from code review
208c2cf 
Co-authored-by: Craze <51416587+RealCrazeOfficial@users.noreply.github.com>
Signed-off-by: FireController#1847 <usfirepilot123@gmail.com>
RealCrazeOfficial
RealCrazeOfficial approved these changes Nov 9, 2025
View reviewed changes
Copy link
Contributor

@RealCrazeOfficial RealCrazeOfficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FireController1847 @RealCrazeOfficial
Apply suggestions from code review
b6054fc 
Co-authored-by: Craze <51416587+RealCrazeOfficial@users.noreply.github.com>
Signed-off-by: FireController#1847 <usfirepilot123@gmail.com>
RealCrazeOfficial
RealCrazeOfficial approved these changes Nov 9, 2025
View reviewed changes
Copy link
Contributor

@RealCrazeOfficial RealCrazeOfficial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FireController1847 FireController1847 merged commit d2ba731 into beta Nov 9, 2025
3 checks passed
@FireController1847
Copy link
Member Author

FireController1847 commented Nov 9, 2025

Thank you everyone for your reviews and efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ThisIsBrady ThisIsBrady ThisIsBrady approved these changes

@RealCrazeOfficial RealCrazeOfficial RealCrazeOfficial approved these changes

Assignees

@FireController1847 FireController1847

Labels

ACT: Review A pull request which is currently under review. CAT: Feature Request A category of issues which are feature requests. P4: High Priority A bug or feature request that needs to be resolved relatively soon.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FireController1847 @ThisIsBrady @RealCrazeOfficial