Skip to content

Conversation

@irubido
Copy link
Collaborator

@irubido irubido commented Feb 25, 2025

Closing banner UI

Screenshot from 2025-02-25 17-57-59
Screenshot from 2025-02-25 11-04-49
Screenshot from 2025-02-25 11-04-38

@CLAassistant
Copy link

CLAassistant commented Feb 25, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ sadiq1971
❌ irubido
You have signed the CLA already but the status is still pending? Let us recheck it.

irubido and others added 2 commits February 26, 2025 10:54
Co-authored-by: Josh <54408698+joshdougall@users.noreply.github.com>
Co-authored-by: Josh <54408698+joshdougall@users.noreply.github.com>
Copy link
Contributor

@joshdougall joshdougall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sadiq1971 sadiq1971 merged commit 66b6cc7 into dev Feb 27, 2025
3 of 6 checks passed
@sadiq1971 sadiq1971 deleted the irubido/closingBanner branch February 27, 2025 13:31
sadiq1971 added a commit that referenced this pull request Mar 11, 2025
* Closing Banner (#2276)

* closing banner

* email

* storage closing banner

* remove unused

* Update packages/files-ui/src/Components/Elements/Banner.tsx

Co-authored-by: Josh <54408698+joshdougall@users.noreply.github.com>

* Update packages/storage-ui/src/Components/Elements/Banner.tsx

Co-authored-by: Josh <54408698+joshdougall@users.noreply.github.com>

* fix: lint

---------

Co-authored-by: Josh <54408698+joshdougall@users.noreply.github.com>
Co-authored-by: sadiq1971 <sadiqurr8@gmail.com>

* Closing Banner Updated (#2277)

* closing banner

* email

* storage closing banner

* remove unused

* Update packages/files-ui/src/Components/Elements/Banner.tsx

Co-authored-by: Josh <54408698+joshdougall@users.noreply.github.com>

* Update packages/storage-ui/src/Components/Elements/Banner.tsx

Co-authored-by: Josh <54408698+joshdougall@users.noreply.github.com>

* fix: lint

* fix: banner updated

* fix: lint ci

---------

Co-authored-by: irubido <ivan.rubido@gmail.com>
Co-authored-by: Ivan Rubido <51483483+irubido@users.noreply.github.com>
Co-authored-by: Josh <54408698+joshdougall@users.noreply.github.com>

---------

Co-authored-by: Ivan Rubido <51483483+irubido@users.noreply.github.com>
Co-authored-by: Josh <54408698+joshdougall@users.noreply.github.com>
Co-authored-by: irubido <ivan.rubido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants