Skip to content

Conversation

@CassidyMabey
Copy link

sorry for before either my git bugged or im an idiot. probably the latter.

Added TridentListener to deal with trident usage
Added changable trident cooldown (default 10 seconds)
Added option to completely stop tridents from being used (set cooldown to -1)
Integrated with combat tagging system
Added config option: Trident Cooldown under Combat Tag section
Versions tested on:
1.21.8
1.21.5

Built with:
java 21
Gradle 8.14.3

Also checking that this will be on lite version 🙏

@deepsource-io
Copy link
Contributor

deepsource-io bot commented Nov 24, 2025

Here's the code health analysis summary for commits d53e0e6..e93f51c. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Java LogoJava✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@ChanceSD
Copy link
Owner

And this works right? You didn't just fully AI generate all of it without testing I hope.
I will give it a few tests soon

@CassidyMabey
Copy link
Author

CassidyMabey commented Nov 24, 2025

And this works right? You didn't just fully AI generate all of it without testing I hope. I will give it a few tests soon

https://github.com/ptthanh02/celestcombat/blob/main/src/main/java/dev/nighter/celestCombat/listeners/TridentListener.java
i used to use this plugin but i just copied the basic part from this and then connected it to your plugin. Built fine and worked in game.
but if they used AI to generate it i have no idea 🤷

tested on a paper server version of:
1.21.8
1.21.5

@ChanceSD
Copy link
Owner

Oh I see, well I don't know if it's AI either, just the code comments look like what AI usually generates but maybe they were just good at commenting everything. Anyway, I will try testing that tomorrow, if it's all well I'll merge it

@ChanceSD
Copy link
Owner

How did you test this if it doesn't compile? There's no expire untag reason for example...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants