Skip to content

changes #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Christrevino22 wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

changes #13

Christrevino22 wants to merge 1 commit into from

Conversation

@Christrevino22
Copy link
Owner

@Christrevino22 Christrevino22 commented Jul 25, 2020 •
edited
Loading

Checkpoint Rubric

This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.

Checkpoint 1

  • All tests passed: 40 points
  • Proper use of documentation (commenting on code): 15 points
  • Properly indented code: 15 points
  • Demonstrated effective use of JavaScript: 30 points

Checkpoint 2

  • The application works as it should: 40 points
  • Proper use of documentation (commenting on code): 15 points
  • Properly indented code: 15 points
  • Demonstrated effective use of JavaScript and the DOM API: 30 points

Checkpoint 3

  • Use of React: 25 points
  • Accesses an API: 25 points
  • Proper use of documentation (commenting on code): 25 points
  • The application functions as it should: 25 points

yousifS
yousifS reviewed Jul 28, 2020
View reviewed changes
08week/AddressBook/addy.js
const button = document.createElement("button");
button.innerHTML = "more info";
button.onclick = function () {
const contactDetails = document.createTextNode(
Copy link

@yousifS yousifS Jul 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would have been nice if you added a toggle, to hid and show the extra info, instead of always appending more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yousifS yousifS yousifS left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Christrevino22 @yousifS