Upgrade xml-crypto from ^0.10.0 to ^2.0.0 #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we put priority on which tags are present for Signature validation (AuthnRequest < Response < Assertion), it's possible for a crafted SAML request to validate the signature for a particular tag, which is invalid for the request. Guard against this by selecting for the signature by starting from the root document element, as we've done so in the past.
the xml dsig namespace can be specified at the root of the SAML response instead of on each Signature element. The canonincalized xml for the signature element requires that the namespace declaration be present on the siganture element.
mcab
commented
Feb 4, 2021
| sig = new xmlcrypto.SignedXml() | ||
| sig.keyInfoProvider = getKey: -> format_pem(certificate, 'CERTIFICATE') | ||
| sig.loadSignature signature[0].toString() | ||
| sig.loadSignature signature[0] |
Member
Author
There was a problem hiding this comment.
This change shouldn't be major. xml-crypto would just reparse if it was made into a string.
Member
Author
|
This will get wrapped up as 3.0.0, because of the potential breaking change for signature selection for |
This was referenced Feb 4, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines the work from #215 and partial work from #123.
xml-cryptois vulnerable to weak signatures being improperly validated. See GHSA-c27r-x354-4m68.xml-cryptofrom^0.10.0to^2.0.0madecheck_saml_signatureno longer work.<ds:Signature>declared at the root level still worked as well.