Skip to content

Add Format attribute to saml:NameID tag in logoutRequest #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nielio wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add Format attribute to saml:NameID tag in logoutRequest #271

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c4461b
Update saml2.coffee
Nielio May 5, 2023
27c02d6
add default Format value for saml:NameID on logout request
May 5, 2023
d0b7eda
fix saml:NameID on logout request
May 5, 2023
c28026f
Merge branch 'master' into patch-1
Nielio Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/saml2.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ create_metadata = (entity_id, assert_endpoint, signing_certificates, encryption_
.end()

# Creates a LogoutRequest and returns it as a string of xml.
create_logout_request = (issuer, name_id, session_index, destination) ->
create_logout_request = (issuer, name_id, session_index, destination, nameid_format) ->
id = '_' + crypto.randomBytes( 21 ).toString( 'hex' )
xml = xmlbuilder.create
'samlp:LogoutRequest':
Expand All @@ -95,7 +95,9 @@ create_logout_request = (issuer, name_id, session_index, destination) ->
'@IssueInstant': (new Date()).toISOString()
'@Destination': destination
'saml:Issuer': issuer
'saml:NameID': name_id
'saml:NameID':
'@Value': name_id
'@Format': nameid_format or 'urn:oasis:names:tc:SAML:1.1:nameid-format:unspecified'
'samlp:SessionIndex': session_index
.end()

Expand Down Expand Up @@ -674,7 +676,7 @@ module.exports.ServiceProvider =
create_logout_request_url: (identity_provider, options, cb) =>
identity_provider = { sso_logout_url: identity_provider, options: {} } if _.isString(identity_provider)
options = set_option_defaults options, identity_provider.shared_options, @shared_options
{id, xml} = create_logout_request @entity_id, options.name_id, options.session_index, identity_provider.sso_logout_url
{id, xml} = create_logout_request @entity_id, options.name_id, options.session_index, identity_provider.sso_logout_url, @shared_options.nameid_format
zlib.deflateRaw xml, (err, deflated) =>
return cb err if err?
try
Expand Down