Skip to content

Conversation

@chad3814
Copy link
Contributor

- this should fix Clever#57 and Clever#48; see them for comments
@jefff
Copy link
Contributor

jefff commented Apr 6, 2016

Thanks for the PR! Sorry for the delay in reviewing this.

As a minor change, can you flip the order of the two signature checks in the or so the current behavior is preserved in the default case? In practice, I don't think it actually matters, but it would make me a bit more confident in releasing this as a minor version bump.

@chad3814
Copy link
Contributor Author

chad3814 commented Apr 6, 2016

Sure, no problem

@jefff
Copy link
Contributor

jefff commented Apr 6, 2016

Thanks, lgtm!

@jefff jefff merged commit e938d73 into Clever:master Apr 6, 2016
@jefff
Copy link
Contributor

jefff commented Apr 6, 2016

Published as 1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

signature check fails if whole response is signed

2 participants