Skip to content

Conversation

@JMGilbert
Copy link
Contributor

With the new mortality valuation using alternative incomes elasticities, even the risk neutral damages have an eta now. This PR provides the infrastructure to deal with an eta dimension in the input damages.


mean_cc = f"{self.ce_path}/adding_up_cc.zarr"
mean_no_cc = f"{self.ce_path}/adding_up_no_cc.zarr"
mean_cc = f"{self.ce_path}/adding_up_cc_eta{self.eta}.zarr"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting for the future that we should go ahead and make the whole filepath an arg in self so that these sorts of code changes aren't necessary.

scaling_deaths = "epa_row"
scaling_costs = "epa_scaled"
valuation = "vsl"
elif mortality_version == 9:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mortality version 9 is a new one to me. Need to add this to our documentation. Also, we need to add brief comments in here about what each version means (or at least what the string values mean).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The theory behind the naming scheme is that versions 1-5 use VSL valuation and 6-10 use the same scaling deaths and costs, but with VLY instead. Version 9 has an extra wrench thrown in, which is that it uses a $2 million VSL in 2025 (2025 USD). This was an MG request for his book spec of the regional SCCs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @JMGilbert! Is that theory on versioning documented anywhere else?

@codecov
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 68.98%. Comparing base (49eda98) to head (5788e3b).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/dscim/preprocessing/preprocessing.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
+ Coverage   68.94%   68.98%   +0.03%     
==========================================
  Files          15       15              
  Lines        1755     1757       +2     
==========================================
+ Hits         1210     1212       +2     
  Misses        545      545              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants