-
Notifications
You must be signed in to change notification settings - Fork 4
Input damages eta dimension #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
||
| mean_cc = f"{self.ce_path}/adding_up_cc.zarr" | ||
| mean_no_cc = f"{self.ce_path}/adding_up_no_cc.zarr" | ||
| mean_cc = f"{self.ce_path}/adding_up_cc_eta{self.eta}.zarr" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting for the future that we should go ahead and make the whole filepath an arg in self so that these sorts of code changes aren't necessary.
| scaling_deaths = "epa_row" | ||
| scaling_costs = "epa_scaled" | ||
| valuation = "vsl" | ||
| elif mortality_version == 9: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mortality version 9 is a new one to me. Need to add this to our documentation. Also, we need to add brief comments in here about what each version means (or at least what the string values mean).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The theory behind the naming scheme is that versions 1-5 use VSL valuation and 6-10 use the same scaling deaths and costs, but with VLY instead. Version 9 has an extra wrench thrown in, which is that it uses a $2 million VSL in 2025 (2025 USD). This was an MG request for his book spec of the regional SCCs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @JMGilbert! Is that theory on versioning documented anywhere else?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #417 +/- ##
==========================================
+ Coverage 68.94% 68.98% +0.03%
==========================================
Files 15 15
Lines 1755 1757 +2
==========================================
+ Hits 1210 1212 +2
Misses 545 545 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
With the new mortality valuation using alternative incomes elasticities, even the risk neutral damages have an eta now. This PR provides the infrastructure to deal with an eta dimension in the input damages.