Feedback #1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. Add additional test directly testing method like LeadTriggerHandler.handleTitleNormalization |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,218 @@ | ||
| /** | ||
| * This class contains unit tests for validating the behavior of | ||
| * Apex class LeadTriggerHandler | ||
| * and trigger LeadTrigger. | ||
| * | ||
| * Implemented by Oxana Suvorova | ||
| */ | ||
| @isTest | ||
| private class LeadTriggerHandlerTest { | ||
|
|
||
| /* | ||
| * LeadTriggerHandler.handleTitleNormalization insert test | ||
| */ | ||
| @isTest | ||
| static void testHandleTitleNormalization_insert() { | ||
| // Prepare the test data | ||
| List<String> titles = new List<String>{ | ||
| 'vp', 'v.p.', 'vice president', 'VPOTUS', 'V.P.', 'vice person', // 5 'Vice President' | ||
| 'mgr', 'manage', 'head of department', '', 'Manager', // 4 'Manager' | ||
| 'exec', 'chief', 'head', 'Chief Executive', null, // 4 'Executive' | ||
| 'assist', 'deputy', 'jr', 'DEPUTY', 'junior'}; // 4 'Assistant' | ||
|
|
||
| List<Lead> leadsToInsert = TestDataFactory.createLeadsByTitle(titles, false); | ||
|
|
||
| // Perform the test | ||
| Test.startTest(); | ||
| Database.insert(leadsToInsert); | ||
| Test.stopTest(); | ||
|
|
||
| // Retrieve the count of Leads grouped by Title | ||
| List<AggregateResult> groupedLeads = [ | ||
| SELECT | ||
| Title, | ||
| COUNT(Name) aggCount | ||
| FROM Lead | ||
| GROUP BY Title | ||
| ]; | ||
|
|
||
| Map<String, Integer> countsByTitle = new Map<String, Integer>(); | ||
| Integer totalRecords = 0; | ||
| for (AggregateResult ar : groupedLeads) { | ||
| totalRecords += (Integer) ar.get('aggCount'); | ||
| countsByTitle.put((String) ar.get('Title'), (Integer) ar.get('aggCount')); | ||
| } | ||
|
|
||
| // Assert that the Title have been correctly changed | ||
| Assert.isTrue(countsByTitle.get('Vice President') == 5, 'Expected 5 Leads with Title \'Vice President\''); | ||
| Assert.isTrue(countsByTitle.get('Manager') == 4, 'Expected 4 Leads with Title \'Manager\''); | ||
| Assert.isTrue(countsByTitle.get('Executive') == 4, 'Expected 4 Leads with Title \'Executive\''); | ||
| Assert.isTrue(countsByTitle.get('Assistant') == 4, 'Expected 4 Leads with Title \'Assistant\''); | ||
| Assert.areEqual(21, totalRecords, 'Expected 21 Lead records'); | ||
| } | ||
|
|
||
| /* | ||
| * LeadTriggerHandler.handleTitleNormalization update test | ||
| */ | ||
| @isTest | ||
| static void testHandleTitleNormalization_update() { | ||
| // Prepare the test data | ||
| List<String> titles = new List<String>{'asist', 'depty', 'junior', null, ''}; | ||
| List<Lead> leadsToUpdate = TestDataFactory.createLeadsByTitle(titles, true); | ||
|
|
||
| for (Lead lead : leadsToUpdate) { | ||
| lead.Title = 'jr'; | ||
| } | ||
| // Perform the test | ||
| Test.startTest(); | ||
| Database.update(leadsToUpdate); | ||
| Test.stopTest(); | ||
|
|
||
| // Retrieve updated Leads | ||
| List<Lead> leadsAfterUpdate = [ | ||
| SELECT | ||
| Title | ||
| FROM Lead | ||
| WHERE Id IN :leadsToUpdate | ||
| ]; | ||
|
|
||
| // Assert that the Title have been correctly updated | ||
| Assert.isTrue(leadsAfterUpdate.size() == 5, 'Expected 5 Lead records'); | ||
| for (Lead lead : leadsAfterUpdate) { | ||
| Assert.areEqual('Assistant', lead.Title, 'Expected Title \'Assistant\''); | ||
| } | ||
| } | ||
|
|
||
| /* | ||
| * LeadTriggerHandler.handleTitleNormalization update test | ||
| */ | ||
| @isTest | ||
| static void testHandleAutoLeadScoring() { | ||
| // Prepare the test data | ||
| List<Map<String, Object>> params = new List<Map<String, Object>>(); | ||
| params.add(new Map<String, Object>{'Lead_Score__c' => 20, 'LeadSource' => null}); // 0 | ||
| params.add(new Map<String, Object>{'LeadSource' => 'Other', 'Email' => 'test@mail.com'}); // 0 | ||
| params.add(new Map<String, Object>{'LeadSource' => 'Web', 'Email' => 'test@mail.com'}); // 3 | ||
| params.add(new Map<String, Object>{'Phone' => '(908)345-1234', 'Industry' => 'Government'}); // 5 | ||
| params.add(new Map<String, Object>{'LeadSource' => 'Web', 'Email' => 'test2@mail.com', 'Phone' => '(908)345-2345'}); // 8 | ||
| params.add(new Map<String, Object>{'Lead_Score__c' => 10, 'Email' => 'test3@mail.com', 'Industry' => 'Technology'}); // 10 | ||
| params.add(new Map<String, Object>{'LeadSource' => 'Web', 'Email' => 'test4@mail.com', 'Industry' => 'Technology'}); // 13 | ||
| params.add(new Map<String, Object>{'LeadSource' => 'Web', 'Phone' => '(908)346-1234', 'Industry' => 'Technology'}); // 15 | ||
| params.add(new Map<String, Object>{'LeadSource' => 'Web', 'Email' => 'test5@mail.com', | ||
| 'Phone' => '(908)346-1234', 'Industry' => 'Technology'}); // 18 | ||
|
|
||
| List<Lead> leadsToScore = TestDataFactory.createLeadsByParams(params, false); | ||
|
|
||
| // Perform the test | ||
| Test.startTest(); | ||
| LeadTriggerHandler.handleAutoLeadScoring(leadsToScore); | ||
| Test.stopTest(); | ||
|
|
||
| // Assert that the Score calculates correctly | ||
| List<Integer> scoreVariants = new List<Integer>{0, 0, 3, 5, 8, 10, 13, 15, 18}; | ||
| for (Integer i = 0; i < leadsToScore.size(); i++) { | ||
| Assert.isTrue(leadsToScore[i].Lead_Score__c <= 18, 'Lead score shouldn\'t be more than 18'); | ||
| Assert.areEqual(scoreVariants[i], leadsToScore[i].Lead_Score__c, 'Score has not correctly calculated'); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| @isTest | ||
| static void testHandleLeadAutoConvert_insertPositive() { | ||
| // Prepare the test data | ||
| TestDataFactory.generateAccountWithContacts(50, 7); // 7 contacts with a unique email | ||
| Map<String, Object> params = new Map<String, Object>{'LeadSource' => 'Web', 'Email' => 'test'}; | ||
| List<Lead> leads = TestDataFactory.createLeadsWithParams(50, params, false); | ||
|
|
||
| // Perform the test | ||
| Test.startTest(); | ||
| Database.insert(leads); | ||
| Test.stopTest(); | ||
|
|
||
| // Request resulted Leads | ||
| List<Lead> insertedLeads = [ | ||
| SELECT Id, Email, IsConverted | ||
| FROM Lead | ||
| ]; | ||
| // Assertions | ||
| Assert.isTrue(insertedLeads.size() == 50, 'Expected 50 Leads inserted'); | ||
| Integer converted = 0; | ||
| for (Integer i = 0; i < 50; i++) { | ||
| if (i > 0 && Math.mod(i, 7) == 0) { | ||
| Assert.isTrue(insertedLeads[i].IsConverted, 'Lead with email ' + insertedLeads[i].Email + ' expected to be converted'); | ||
| converted++; | ||
| } else { | ||
| Assert.isFalse(insertedLeads[i].IsConverted, 'Lead with email ' + insertedLeads[i].Email + ' shouldn\t be converted'); | ||
| } | ||
| } | ||
| Assert.isTrue(converted == 7, 'Expected 7 Leads converted'); | ||
| } | ||
|
|
||
| @isTest | ||
| static void testHandleLeadAutoConvert_insertNegative() { | ||
| // Prepare the test data | ||
| TestDataFactory.generateAccountWithContacts(5, 2); // 2 contacts with a unique email | ||
| Map<String, Object> params = new Map<String, Object>{'LeadSource' => 'Web', | ||
| 'Status' => 'Closed - Converted', | ||
| 'Email' => 'test'}; | ||
| List<Lead> leads = TestDataFactory.createLeadsWithParams(5, params, false); | ||
|
|
||
| // Perform the test | ||
| Test.startTest(); | ||
| Database.insert(leads); | ||
| Test.stopTest(); | ||
|
|
||
| // Request resulted Leads | ||
| List<Lead> insertedLeads = [ | ||
| SELECT | ||
| Id, | ||
| Email, | ||
| IsConverted | ||
| FROM Lead | ||
| ]; | ||
| // Assertions | ||
| Assert.isTrue(insertedLeads.size() == 5, 'Expected 5 Leads inserted'); | ||
| for (Lead lead : insertedLeads) { | ||
| Assert.isFalse(lead.IsConverted, 'Lead should\'t be converted'); | ||
| } | ||
| } | ||
|
|
||
| @isTest | ||
| static void testHandleLeadAutoConvert_update() { | ||
| // Prepare the test data | ||
| TestDataFactory.generateAccountWithContacts(5, 2); // 2 contacts with a unique email | ||
| Map<String, Object> params = new Map<String, Object>{'LeadSource' => 'Web'}; | ||
| List<Lead> leads = TestDataFactory.createLeadsWithParams(2, params, true); | ||
|
|
||
| // Change email | ||
| List<Lead> leadsToUpdate = [ | ||
| SELECT | ||
| Id, | ||
| FROM Lead | ||
| WHERE Id IN :leads | ||
| AND IsConverted = false | ||
| ]; | ||
| Assert.areEqual(2, leadsToUpdate.size(), 'Expected to get 2 unconverted Leads'); | ||
| leadsToUpdate[0].Email = 'test0@mail.com'; // not going to be converted | ||
| leadsToUpdate[1].Email = 'test1@mail.com'; // going to be converted | ||
|
|
||
| // Perform the test | ||
| Test.startTest(); | ||
| Database.update(leadsToUpdate); | ||
| Test.stopTest(); | ||
|
|
||
| // Request resulted Leads | ||
| List<Lead> updatedLeads = [ | ||
| SELECT | ||
| Id, | ||
| Email, | ||
| IsConverted | ||
| FROM Lead | ||
| WHERE Id IN :leadsToUpdate | ||
| ]; | ||
| // Assertions | ||
| Assert.isFalse(updatedLeads[0].IsConverted, 'Lead with email ' + updatedLeads[0].Email + ' shouldn\'t be converted'); | ||
| Assert.isTrue(updatedLeads[1].IsConverted, 'Lead with email ' + updatedLeads[1].Email + ' expected to be converted'); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <ApexClass xmlns="http://soap.sforce.com/2006/04/metadata"> | ||
| <apiVersion>59.0</apiVersion> | ||
| <status>Active</status> | ||
| </ApexClass> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all of these examples try create a contains the values that you are looking for then do contain on the list.