Object ID Auto-Generation and Constructor Overloads #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- EventQueue running flag was not checked in all methods - Event serial numbering did not behave as expected in all cases - Incomplete simulation reset, not all global state was reset on an init call - Unsynchronized access to CloudSim.paused
- added an atomic int in each class that needs IDs - updated CloudSimExampleTest (where IDs were not intentionally duplicated) to use the new overloads - fixed CloudSimExample5 that did not increment IDs between cloudlet instantiations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces a parallel API that removes the need to manually specify IDs when creating:
Container,ContainerVm,PowerContainer,PowerContainerVm,Cloudlet,Host,HostDynamicWorkload,Pe, andVm.Each class family now maintains an internal atomic counter that increments when new instances are created.
If an instance is created manually with a provided ID, the counter updates to the maximum of the previous value and the given ID.
The
CloudSimExample*examples have been updated to demonstrate the new API.