West Midlands | ITP-Sept-25 | Mustaf Asani | Sprint 2 | Data groups coursework #934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n implement folder
…works as expected
…in querystring test suite
asaniDev
added
📅 Sprint 2
cjyuan
reviewed
Dec 16, 2025
cjyuan
added
Reviewed
asaniDev
added
the
Needs Review
cjyuan
reviewed
Dec 17, 2025
cjyuan
removed
the
Needs Review
in querystring file and refactored tally.js to use itemcount
asaniDev
added
Needs Review
cjyuan
reviewed
Dec 18, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
You are doing great. tally.js could still use some improvement.
| let n = 0; | ||
|
|
||
| while (inputArray.length > 0) { | ||
| itemCount = 0; |
Contributor
There was a problem hiding this comment.
itemCount is used only inside the while loop, so it is best practice to declare the variable here (in the block { ... } where the variable is being used)
|
|
||
| while (inputArray.length > 0) { | ||
| itemCount = 0; | ||
| const tempArray = []; |
Contributor
There was a problem hiding this comment.
Can your code work without using tempArray?
| i--; | ||
| } | ||
|
|
||
| if (itemCount > 0) { |
Contributor
There was a problem hiding this comment.
Is this check necessary? Under what circumstances will itemCount be 0 or less?
cjyuan
removed
the
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed the debug, implement and interpret tasks