Feature/clh/add standardrb

app/controllers/application_controller.rb

@@ -19,15 +19,17 @@ def set_locale
     end
   end
 
+  # rubocop:disable Style/UnlessLogicalOperators
   def redirect_to_maintenance
     if Settings&.maintenance&.maintenance_mode && !current_user
-      unless self.class == Users::SessionsController &&
+      unless instance_of?(Users::SessionsController) &&
           ((Settings.maintenance.maintenance_token && params[:maintenance_token] == Settings.maintenance.maintenance_token) || params[:format] == "json")
         redirect_to Settings.maintenance.maintenance_page,
           allow_other_host: true
       end
     end
   end
+  # rubocop:enable Style/UnlessLogicalOperators
 
   protected
 
@@ -62,7 +64,7 @@ def render_json(&block)
     rescue ExpiredTokenError => e
       logger.info "422: #{e}".red.bold
       result = {status: 422, json: {error: e.message}}
-    rescue Exception => e # a non-validation related exception
+    rescue => e # a non-validation related exception
       logger.error "500: #{e}".red.bold
       logger.error e.backtrace.take(5).map { |l| ">>".red.bold + " #{l}" }.join("\n").red
       result = {status: 500, json: {error: e.message, backtrace: e.backtrace}}
@@ -147,7 +149,7 @@ def after_inactive_sign_up_path_for(resource)
   private
 
   def current_user_id
-    current_user && current_user.id
+    current_user&.id
   end
 
   # Overload handle_unverified_request to ensure that

app/controllers/campaigns/donations_controller.rb

@@ -8,7 +8,7 @@ class DonationsController < ApplicationController
     def index
       respond_to do |format|
         format.csv do
-          file_date = Date.today.strftime("%m-%d-%Y")
+          file_date = Time.zone.today.strftime("%m-%d-%Y")
           donations = QueryDonations.campaign_export(current_campaign.id)
           send_data(Format::Csv.from_vectors(donations), filename: "campaign-donations-#{file_date}.csv")
         end

app/controllers/campaigns_controller.rb

@@ -67,7 +67,7 @@ def create
       json_saved campaign, "Campaign created! Well done."
     else
       profile_id = params[:campaign][:profile_id]
-      Profile.find(profile_id).update_attributes params[:profile]
+      Profile.find(profile_id).update params[:profile]
       render json: CreatePeerToPeerCampaign.create(params[:campaign], profile_id)
     end
   end
@@ -76,7 +76,7 @@ def update
     Time.use_zone(current_nonprofit.timezone || "UTC") do
       params[:campaign][:end_datetime] = Chronic.parse(params[:campaign][:end_datetime]) if params[:campaign][:end_datetime].present?
     end
-    current_campaign.update_attributes params[:campaign]
+    current_campaign.update params[:campaign]
 
     json_saved current_campaign, "Successfully updated!"
   end

app/controllers/concerns/controllers/api_new/jbuilder_expansions.rb

@@ -403,6 +403,12 @@ def leaf?
       end
     end
 
+    def self.create_from(root_tree_node)
+      er = ExpansionTree.new
+      er.root_node = root_tree_node
+      er
+    end
+
     private
 
     # given a set of SPaths, build a tree to describe
@@ -415,11 +421,5 @@ def parse_paths(paths = [])
         end
       end
     end
-
-    def self.create_from(root_tree_node)
-      er = ExpansionTree.new
-      er.root_node = root_tree_node
-      er
-    end
   end
 end

app/controllers/events_controller.rb

@@ -43,7 +43,7 @@ def update
       params[:event][:start_datetime] = Chronic.parse(params[:event][:start_datetime]) if params[:event][:start_datetime].present?
       params[:event][:end_datetime] = Chronic.parse(params[:event][:end_datetime]) if params[:event][:end_datetime].present?
     end
-    current_event.update_attributes(params[:event])
+    current_event.update(params[:event])
     json_saved current_event, "Successfully updated"
   end
 

app/controllers/image_attachments_controller.rb

@@ -13,7 +13,7 @@ def create
   end
 
   def remove
-    @image = ImageAttachment.select { |img| img.file_url == params[:src] }.first
+    @image = ImageAttachment.find { |img| img.file_url == params[:src] }
     if @image
       @image.destroy
       render json: @image

app/controllers/nonprofits/custom_field_joins_controller.rb

@@ -20,7 +20,7 @@ def modify
       end
 
       supporter_ids = if params[:selecting_all]
-        QuerySupporters.full_filter_expr(current_nonprofit.id, params[:query]).select("supporters.id").execute.map { |h| h["id"] }
+        QuerySupporters.full_filter_expr(current_nonprofit.id, params[:query]).select("supporters.id").execute.pluck("id")
       else
         params[:supporter_ids].map(&:to_i)
       end

app/controllers/nonprofits/nonprofit_keys_controller.rb

@@ -27,7 +27,7 @@ def mailchimp_landing
       session.delete(:current_mailchimp_nonprofit_id)
       begin
         session[:mailchimp_access_token] = InsertNonprofitKeys.insert_mailchimp_access_token(@nonprofit.id, params[:code])
-      rescue Exception => e
+      rescue => e
         flash[:notice] = "Unable to connect to your Mailchimp account, please try again. (Error: #{e})"
         redirect_to "/settings"
         return

app/controllers/nonprofits/payments_controller.rb

@@ -43,7 +43,7 @@ def show
 
     def update
       @payment = current_nonprofit.payments.find(params[:id])
-      @payment.update_attributes(params[:payment])
+      @payment.update(params[:payment])
       json_saved @payment
     end
 

app/controllers/nonprofits/stripe_accounts_controller.rb

@@ -29,7 +29,7 @@ def begin_verification
       StripeAccountUtils.find_or_create(current_nonprofit.id)
       current_nonprofit.reload
 
-      status = NonprofitVerificationProcessStatus.where("stripe_account_id = ?", current_nonprofit.stripe_account_id).first
+      status = NonprofitVerificationProcessStatus.where(stripe_account_id: current_nonprofit.stripe_account_id).first
       status ||= NonprofitVerificationProcessStatus.new(stripe_account_id: current_nonprofit.stripe_account_id)
 
       unless status.started_at

app/controllers/nonprofits/supporter_notes_controller.rb

@@ -12,7 +12,7 @@ def create
 
     # put /nonprofits/:nonprofit_id/supporters/:supporter_id/supporter_notes/:id
     def update
-      params[:supporter_note][:user_id] ||= current_user && current_user.id
+      params[:supporter_note][:user_id] ||= current_user&.id
       params[:supporter_note][:id] = params[:id]
       render_json { UpdateSupporterNotes.update(params[:supporter_note]) }
     end

app/controllers/nonprofits/supporters_controller.rb

@@ -3,7 +3,7 @@ module Nonprofits
   class SupportersController < ApplicationController
     include Controllers::NonprofitHelper
 
-    before_action :authenticate_nonprofit_user!, except: [:new, :create]
+    before_action :authenticate_nonprofit_user!, except: [:create]
 
     before_action :validate_allowed!, only: [:create]
     rescue_from ::TempBlockError, with: :handle_temp_block_error
@@ -19,7 +19,7 @@ def index
         end
 
         format.csv do
-          file_date = Date.today.strftime("%m-%d-%Y")
+          file_date = Time.zone.today.strftime("%m-%d-%Y")
           supporters = QuerySupporters.for_export(params[:nonprofit_id], params)
           send_data(Format::Csv.from_vectors(supporters), filename: "supporters-#{file_date}.csv")
         end
@@ -82,7 +82,7 @@ def update
 
     def bulk_delete
       supporter_ids = if params[:selecting_all]
-        QuerySupporters.full_filter_expr(current_nonprofit.id, params[:query]).select("supporters.id").execute.map { |h| h["id"] }
+        QuerySupporters.full_filter_expr(current_nonprofit.id, params[:query]).select("supporters.id").execute.pluck("id")
       else
         params[:supporter_ids].map(&:to_i)
       end

app/controllers/nonprofits/tag_joins_controller.rb

@@ -14,7 +14,7 @@ def index
     # selected supporters' tags or all supporters' tags
     def modify
       supporter_ids = if params[:selecting_all]
-        QuerySupporters.full_filter_expr(current_nonprofit.id, params[:query]).select("supporters.id").execute.map { |h| h["id"] }
+        QuerySupporters.full_filter_expr(current_nonprofit.id, params[:query]).select("supporters.id").execute.pluck("id")
       else
         params[:supporter_ids].map(&:to_i)
       end

app/controllers/nonprofits_controller.rb

@@ -56,7 +56,7 @@ def create
 
   def update
     flash[:notice] = "Update successful!"
-    current_nonprofit.update_attributes params[:nonprofit].except(:verification_status)
+    current_nonprofit.update params[:nonprofit].except(:verification_status)
     current_nonprofit.clear_cache
     json_saved current_nonprofit
   end
@@ -129,7 +129,7 @@ def countries_list(locale)
     all_countries = ISO3166::Country.translations(locale)
 
     if Settings.intntl.all_countries
-      countries = all_countries.select { |code, name| Settings.intntl.all_countries.include? code }
+      countries = all_countries.slice(*Settings.intntl.all_countries)
       countries = countries.map { |code, name| [code.upcase, name] }.sort_by { |a| a[1] }
       countries.push([Settings.intntl.other_country.upcase, I18n.t("nonprofits.donate.info.supporter.other_country")]) if Settings.intntl.other_country
       countries

app/controllers/profiles_controller.rb

@@ -45,7 +45,7 @@ def update
     else
       current_user.profile
     end
-    @profile.update_attributes(params[:profile])
+    @profile.update(params[:profile])
     json_saved @profile, "Profile updated"
   end
 

app/controllers/recurring_donations_controller.rb

@@ -43,7 +43,7 @@ def update
   end
 
   def update_amount
-    rd = RecurringDonation.where("id = ?", params[:id]).first
+    rd = RecurringDonation.where(id: params[:id]).first
     if rd && params[:edit_token] == rd["edit_token"]
       begin
         amount_response = UpdateRecurringDonations.update_amount(rd, params[:token], params[:amount], params[:fee_covered])
@@ -61,8 +61,8 @@ def update_amount
 
   def print_currency(cents, unit = "EUR", sign = true)
     dollars = cents.to_f / 100.0
-    dollars = view_context.number_to_currency(dollars, unit: "#{unit}", precision: (dollars.round == dollars) ? 0 : 2)
-    dollars = dollars[1..-1] if !sign
+    dollars = view_context.number_to_currency(dollars, unit: unit.to_s, precision: (dollars.round == dollars) ? 0 : 2)
+    dollars = dollars[1..] if !sign
     dollars
   end
 end

app/controllers/static_controller.rb

@@ -7,19 +7,27 @@ def terms_and_privacy
   end
 
   def ccs
-    ccs_method = (!Settings.ccs) ? "local_tar_gz" : Settings.ccs.ccs_method
-    if ccs_method == "local_tar_gz"
-      temp_file = "#{Rails.root.join("tmp/#{Time.current.to_i}.tar.gz")}"
-      result = Kernel.system("git archive --format=tar.gz -o #{temp_file} HEAD")
-      if result
-        send_file(temp_file, type: "application/gzip")
-      else
-        head 500
-      end
-    elsif ccs_method == "github"
-      git_hash = File.read("#{Rails.root.join("CCS_HASH")}")
+    if Settings.ccs&.ccs_method.presence == "github"
       redirect_to "https://github.com/#{Settings.ccs.options.account}/#{Settings.ccs.options.repo}/tree/#{git_hash}",
         allow_other_host: true
+    elsif create_archive
+      send_file(temp_file, type: "application/gzip")
+    else
+      head 500
     end
   end
+
+  private
+
+  def git_hash
+    @git_hash ||= File.read(Rails.root.join("CCS_HASH").to_s)
+  end
+
+  def temp_file
+    @temp_file ||= Rails.root.join("tmp/#{Time.current.to_i}.tar.gz").to_s
+  end
+
+  def create_archive
+    Kernel.system("git archive --format=tar.gz -o #{temp_file} HEAD")
+  end
 end

app/controllers/super_admins_controller.rb

@@ -18,7 +18,7 @@ def search_profiles
   def search_fullcontact
     begin
       result = FullContact.person(email: params[:search])
-    rescue Exception
+    rescue
       result = ""
     end
     render json: [result]
@@ -29,7 +29,7 @@ def resend_user_confirmation
       profile_id: {required: true, is_integer: true}
     })
 
-    profile = Profile.includes(:user).where("id = ?", params[:profile_id]).first
+    profile = Profile.includes(:user).where(id: params[:profile_id]).first
     unless profile.user
       raise ArgumentError.new("#{params[:profile_id]} is a profile without a valid user")
     end
@@ -56,7 +56,7 @@ def recurring_donations_without_cards
           }
         }
 
-        send_data(csv_out, filename: "recurring_donations_without_cards-#{Time.now.to_date}.csv")
+        send_data(csv_out, filename: "recurring_donations_without_cards-#{Time.zone.now.to_date}.csv")
       end
     end
   end

app/controllers/ticket_levels_controller.rb

@@ -19,7 +19,7 @@ def create
   end
 
   def update
-    current_ticket_level.update_attributes params[:ticket_level]
+    current_ticket_level.update params[:ticket_level]
     json_saved current_ticket_level, "Ticket level updated"
   end
 

app/controllers/tickets_controller.rb

@@ -30,7 +30,7 @@ def index
     respond_to do |format|
       format.html
       format.csv do
-        file_date = Date.today.strftime("%m-%d-%Y")
+        file_date = Time.zone.today.strftime("%m-%d-%Y")
         filename = "tickets-#{file_date}"
         @tickets = QueryTickets.for_export(@event.id, params)
         send_data(Format::Csv.from_vectors(@tickets), filename: "#{filename}.csv")
@@ -44,7 +44,7 @@ def index
 
   # PUT nonprofits/:nonprofit_id/events/:event_id/tickets/:id/add_note
   def add_note
-    current_nonprofit.tickets.find(params[:id]).update_attributes(note: params[:ticket][:note])
+    current_nonprofit.tickets.find(params[:id]).update(note: params[:ticket][:note])
     render json: {}
   end
 

app/controllers/users/confirmations_controller.rb

@@ -23,7 +23,7 @@ def exists
   def confirm
     @user = User.find(params[:id])
 
-    if @user.valid? && @user.update_attributes(params[:user].except(:confirmation_token))
+    if @user.valid? && @user.update(params[:user].except(:confirmation_token))
       flash[:notice] = "Your account is all set!"
       sign_in @user
       redirect_to session[:donor_signup_url] || root_url

app/controllers/users/registrations_controller.rb

@@ -32,7 +32,7 @@ def update
       if current_user.pending_password && params[:user][:password] && params[:user][:password_confirmation]
         params[:user][:pending_password] = false
       end
-      success = current_user.update_attributes(params[:user])
+      success = current_user.update(params[:user])
       errs = current_user.errors.full_messages
     else
       success = false

app/helpers/application_helper.rb

@@ -14,8 +14,8 @@ def devise_mapping
 
   def print_currency(cents, unit = "EUR", sign = true)
     dollars = cents.to_f / 100.0
-    dollars = number_to_currency(dollars, unit: "#{unit}", precision: (dollars.round == dollars) ? 0 : 2)
-    dollars = dollars[1..-1] if !sign
+    dollars = number_to_currency(dollars, unit: unit.to_s, precision: (dollars.round == dollars) ? 0 : 2)
+    dollars = dollars[1..] if !sign
     dollars
   end
 

app/helpers/card_helper.rb

@@ -1,6 +1,6 @@
 # License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later
 module CardHelper
   def expiration_years
-    (0..15).map { |n| (Date.today + n.years).year }
+    (0..15).map { |n| (Time.zone.today + n.years).year }
   end
 end

app/jobs/inline_job.rb

@@ -1,5 +1,5 @@
 # License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later
 # newer versions of Rails use an ApplicationJob so let's be cool like them
-class InlineJob < ActiveJob::Base
+class InlineJob < ApplicationJob
   :inline
 end

app/jobs/mailchimp_nonprofit_user_add_job.rb

@@ -1,6 +1,6 @@
 # License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later
 
-class MailchimpNonprofitUserAddJob < ActiveJob::Base
+class MailchimpNonprofitUserAddJob < ApplicationJob
   queue_as :default
 
   def perform(user, nonprofit)