Remove unused NonprofitsController#create
#1234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwahammy
commented
Jun 26, 2025
Comment on lines
-204
to
-210
| # Register (create) a nonprofit with an initial admin | ||
| def self.register(user, params) | ||
| np = create ConstructNonprofit.construct(user, params) | ||
| Role.create(user: user, name: "nonprofit_admin", host: np) if np.valid? | ||
| np | ||
| end |
Member
Author
There was a problem hiding this comment.
Only used by NonprofitsController#create
wwahammy
commented
Jun 26, 2025
| @@ -1,12 +0,0 @@ | |||
| # License: AGPL-3.0-or-later WITH Web-Template-Output-Additional-Permission-3.0-or-later | |||
Member
Author
There was a problem hiding this comment.
Only used by Nonprofit.register
wwahammy
commented
Jun 26, 2025
| require "get_data" | ||
| require "stripe" | ||
|
|
||
| module CreateStripeAccount |
Member
Author
There was a problem hiding this comment.
Only used by ConstructNonprofit.construct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: DO NOT discuss internal CommitChange information in your PR; this PR will be public.
Link back to the issue in the Tix repo when you need to do that.
When working on #1188, I realized we don't use
NonprofitsController#create. At all. Instead we create Nonprofits through theApi::NonprofitsController#createmethod. There's no reason to keep this other method around. In fact, we shouldn't.I also realized there are some other methods that were only used by that method so I deleted those too.