Ensure refund creates an associated supporter activity record

app/legacy_lib/insert_activities.rb

@@ -82,10 +82,22 @@ def self.insert_tickets_expr
       .add_join("events AS event", "event.id=tickets.event_id")
   end
 
-  def self.for_refunds(payment_ids)
-    insert_refunds_expr
-      .and_where("payments.id IN ($ids)", ids: payment_ids)
-      .execute
+  def self.for_refunds(*payments)
+    payments.map do |payment|
+      refund = payment.refund
+      Activity.create(
+        attachment: payment,
+        supporter: payment.supporter,
+        nonprofit: payment.nonprofit,
+        kind: "Refund",
+        json_data: {
+          gross_amount: payment.gross_amount,
+          reason: refund.reason,
+          email: refund.user&.email
+        },
+        user: refund.user
+      )
+    end
   end
 
   def self.insert_refunds_expr

app/legacy_lib/insert_refunds.rb

@@ -56,7 +56,8 @@ def self.modern_refund(charge, h)
 
       refund.create_misc_refund_info(is_modern: true, stripe_application_fee_refund_id: results[:stripe_app_fee_refund]&.id)
 
-      InsertActivities.for_refunds([payment.id])
+      InsertActivities.for_refunds(payment)
+
       # Update original payment to increment its refund_total for any future refund attempts
       original_payment.refund_total += h["amount"].to_i
       original_payment.save!

spec/lib/insert/insert_refunds_spec.rb

@@ -86,7 +86,7 @@
                       "reason" => reason
                     }, charge_date: charge.created_at
                   ).and_return(perform_stripe_refund_result)
-                  expect(InsertActivities).to receive(:for_refunds)
+                  expect(InsertActivities).to receive(:for_refunds).with(an_instance_of(Payment))
                 end
 
                 let!(:modern_refund_call) do

spec/lib/query/query_payments_spec.rb

@@ -184,7 +184,7 @@ def generate_donation(h)
             "charge" => charge.stripe_charge_id
           }, charge_date: charge.created_at
         ).and_return(perform_stripe_refund_result)
-        expect(InsertActivities).to receive(:for_refunds)
+        expect(InsertActivities).to receive(:for_refunds).with(an_instance_of(Payment))
         InsertRefunds.with_stripe(charge.attributes, {amount: 100}.with_indifferent_access)
       }
 
@@ -196,7 +196,7 @@ def generate_donation(h)
             "charge" => charge.stripe_charge_id
           }, charge_date: charge.created_at
         ).and_return(perform_stripe_refund_result)
-        expect(InsertActivities).to receive(:for_refunds)
+        expect(InsertActivities).to receive(:for_refunds).with(an_instance_of(Payment))
         InsertRefunds.with_stripe(charge.attributes, {amount: 50}.with_indifferent_access)
       }
 
@@ -681,7 +681,7 @@ def generate_donation(h)
             "charge" => charge.stripe_charge_id
           }, charge_date: charge.created_at
         ).and_return(perform_stripe_refund_result)
-        expect(InsertActivities).to receive(:for_refunds)
+        expect(InsertActivities).to receive(:for_refunds).with(an_instance_of(Payment))
         InsertRefunds.with_stripe(charge.attributes, {amount: 100}.with_indifferent_access)
       }
 
@@ -693,7 +693,7 @@ def generate_donation(h)
             "charge" => charge.stripe_charge_id
           }, charge_date: charge.created_at
         ).and_return(perform_stripe_refund_result)
-        expect(InsertActivities).to receive(:for_refunds)
+        expect(InsertActivities).to receive(:for_refunds).with(an_instance_of(Payment))
         InsertRefunds.with_stripe(charge.attributes, {amount: 50}.with_indifferent_access)
       }
 
@@ -774,7 +774,7 @@ def generate_donation(h)
             "charge" => charge.stripe_charge_id
           }, charge_date: charge.created_at
         ).and_return(perform_stripe_refund_result)
-        expect(InsertActivities).to receive(:for_refunds)
+        expect(InsertActivities).to receive(:for_refunds).with(an_instance_of(Payment))
         InsertRefunds.with_stripe(charge.attributes, {amount: 50}.with_indifferent_access)
       }