Skip to content

Conversation

@Locke
Copy link
Contributor

@Locke Locke commented Apr 13, 2018

This upgrades the jParsec dependency to 3.0.

There are some major changes from 2.x (from https://github.com/jparsec/jparsec/releases/tag/3.0-rc1):

  • Java 8 is required
  • "Change package names from org.codehaus.jparsec to org.jparsec"
  • "Adapt code to Java 8 features: Remove various FP-like utilities, use lambdas everywhere..."

I applied the renamed package in 6e51145, and later on in 3fd3972 I followed the deprecation warnings and made use of the new Java 8 API.

Note: I'm not using Eclipse so I haven't tested that part.

@Locke
Copy link
Contributor Author

Locke commented Feb 6, 2019

Just pushed some new commits:

  • rebased onto master
  • fix deprecation of .optional() without default value to use .optional(null)
  • some code style improvements
  • I noticed that in ParserTools.java a lot of methods have an unused name argument. I deprecated those methods and moved their implementation to the methods without the name argument to make clear hat the name argument is unused
  • updated to jParsec 3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant