Skip to content

rename to_array to avoid std conflict #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChaitanyaChawak merged 2 commits into from
Apr 10, 2025
Merged

rename to_array to avoid std conflict #58

ChaitanyaChawak merged 2 commits into from
Apr 10, 2025

Conversation

@sfarrens
Copy link
Member

@sfarrens sfarrens commented Apr 9, 2025

  • Updated C++ standard to 20
  • Updated Pybind11 version to 2.13.6
  • Renamed to_array to convert_to_array to avoid conflict with > C++17 std namespace, need to compile with Apple Clang v17

@sfarrens sfarrens self-assigned this Apr 9, 2025
@sfarrens sfarrens requested a review from ChaitanyaChawak April 9, 2025 16:36
@ChaitanyaChawak ChaitanyaChawak merged commit b8a1976 into master Apr 10, 2025
3 checks passed
@sfarrens sfarrens deleted the clang_v17 branch April 15, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChaitanyaChawak ChaitanyaChawak ChaitanyaChawak approved these changes

Assignees

@sfarrens sfarrens

Labels

bug clean up

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfarrens @ChaitanyaChawak