This repository was archived by the owner on Sep 25, 2019. It is now read-only.
Check-in puma.rb #311
Open
Check-in puma.rb #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jsyeo
commented
Dec 8, 2014
jsyeo
commented
config/puma.rb
Outdated
Member
There was a problem hiding this comment.
no need to set so high. this might cause too many requests to be timesliced on one thread.
Contributor
Author
There was a problem hiding this comment.
how about min = 0, max = 10?
Contributor
Author
There was a problem hiding this comment.
How can I know what's the "right" number? 😕
Member
There was a problem hiding this comment.
I believe for mine I used min=1, max=4... but you might wanna tweak this when you have instrumentation.
Don't daemonize. Don't create pids. Create sockets in /tmp
Contributor
There was a problem hiding this comment.
why this is commented out?
Contributor
|
If this is for our production, you need to check what we have in our production now. Otherwise push this could break things. |
Contributor
|
Also, git ignore file currently ignores: /config/puma.rb |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.