[DEV-3978] Refactor to use Express.Multer.File #2305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidleomay
reviewed
Aug 5, 2025
Comment on lines
+1
to
+4
| export interface FileUploadData { | ||
| fileName: string; | ||
| file: string; // Base64 encoded file content | ||
| } |
Member
There was a problem hiding this comment.
Does it make sense to base64 encode the file buffer and directly decode it again afterwards?
(see KycService. updateFileData)
Comment on lines
+70
to
+71
| @Body() dto: CreateKycLogDto, | ||
| @UploadedFile() file?: Express.Multer.File, |
Member
There was a problem hiding this comment.
Can we use body and file in the same request?
TaprootFreak
force-pushed
the
develop
branch
from
d06a5a8 to
b4b852e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Checklist
Pre-Release
Post-Release