Skip to content

[DEV-3957] partner fee #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Yannick1712 wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

[DEV-3957] partner fee #2491

Yannick1712 wants to merge 13 commits into from

Conversation

@Yannick1712
Copy link
Member

@Yannick1712 Yannick1712 commented Oct 7, 2025

Release Checklist

Pre-Release

  • Check migrations
    • No database related infos (sqldb-xxx)
    • Impact on GS (new/removed columns)
  • Check for linter errors (in PR)
  • Test basic user operations (on DFX services)
    • Login/logout
    • Buy/sell payment request
    • KYC page

Post-Release

  • Test basic user operations
  • Monitor application insights log

@Yannick1712
Copy link
Member Author

Yannick1712 commented Oct 7, 2025 •
edited
Loading

  • add migration
  • adapt services
  • adapt ref payout to payout partnerFees
  • new wallet col (user): owner
  • addition partnerFeeCol in buyCrypto/buyFiat ref (add it to ref calculation)

davidleomay
davidleomay reviewed Oct 14, 2025
View reviewed changes
Copy link
Member

@davidleomay davidleomay left a comment •
edited by Yannick1712
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Improve naming

davidleomay
davidleomay requested changes Nov 12, 2025
View reviewed changes
Copy link
Member

@davidleomay davidleomay left a comment •
edited by Yannick1712
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Implement partner fee payout

@Yannick1712
Copy link
Member Author

Yannick1712 commented Nov 18, 2025 •
edited
Loading

  • adapt migration
  • replace cake wallet fee + set cake wallet owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidleomay davidleomay davidleomay requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Yannick1712 @davidleomay