fix(swap): correct misleading includeTx default value #2792
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes misleading default value in
createSwapPaymentInfoservice method.Problem
The service has
includeTx = trueas default:But the controller always passes an explicit boolean:
When no
?includeTxquery parameter is provided:includeTxin controller =undefinedundefined === 'true'=falseSo the service default is never used, and the actual behavior is
false.Fix
Change default from
truetofalseto accurately reflect actual behavior.This is purely a code clarity fix - no functional change.
Test Plan