Skip to content

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Jan 6, 2026

Automatic Release PR

This PR was automatically created after changes were pushed to develop.

Commits: 1 new commit(s)

Checklist

  • Review all changes
  • Verify CI passes
  • Approve and merge when ready for production

…ster (#2853)

Pimlico's pm_sponsorUserOperation validates the paymaster field and
rejects '0x' as an invalid address. Use the proper zero address
'0x0000000000000000000000000000000000000000' instead.
Reduce the cronjob interval for FiatOutput creation from EVERY_10_MINUTES
to EVERY_MINUTE, cutting maximum wait time by 90%.
@github-actions
Copy link
Author

github-actions bot commented Jan 6, 2026

🤖 PR Review Bot

⚠️ Unverified Commits (2)

The following commits are not signed/verified:

  • 0b15a9d [NO-TASK] Fixed low liquidity transaction priorization (David May)
  • e50e5e5 Fixed app insights query (David May)
How to sign commits
# SSH signing (recommended)
git config --global gpg.format ssh
git config --global user.signingkey ~/.ssh/id_ed25519.pub
git config --global commit.gpgsign true

# Re-sign last commit
git commit --amend -S --no-edit
git push --force-with-lease

⚠️ Non-Conventional Commits (2)

The following commits don't follow conventional commit format:

  • 0b15a9d [NO-TASK] Fixed low liquidity transaction priorization
  • e50e5e5 Fixed app insights query

Expected: type(scope): description
Types: feat, fix, refactor, test, ci, docs, chore, perf, style, build, revert


⚠️ Security: 0 critical, 67 high vulnerabilities


This is an automated review. Please address the issues above.

* fix: persist Yapeal API errors to fiat_output.info column

When Yapeal payment transmission fails, the error message is now
stored in the info column for debugging. Previously errors were
only logged, making it difficult to diagnose repeated failures.

* fix: limit error message to 256 chars (column length) and add error handling

- Fix: info column is limited to 256 chars, not 500
- Add try-catch around DB update to prevent loop interruption

* refactor: only persist error if info field is empty

Avoids unnecessary DB updates on every cron run

* fix: clear YAPEAL error from info field on successful transmission
davidleomay and others added 3 commits January 6, 2026 20:47
* feat: add automatic chargeback processing for bank_tx_return

Add chargebackTx() cronjob that automatically approves refunds when:
- User has confirmed (chargebackAllowedDateUser is set)
- Amount is set (chargebackAmount)
- IBAN is set (chargebackIban)
- No output created yet (chargebackOutput is null)
- User status is OK (not blocked, valid KYC/risk status)

This aligns bank_tx_return with buy_crypto/buy_fiat behavior where
refunds are automatically processed after user confirmation.

* fix: add user.status check to chargebackTx for consistency

Add transaction.user.status check to align with buy_crypto and buy_fiat
chargebackTx implementations. Only process refunds when user status is
NA or ACTIVE, preventing automatic refunds for blocked/deleted users.
@TaprootFreak TaprootFreak merged commit 8da318e into master Jan 6, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants