feat(aml): add NAME_TOO_SHORT check for bank payout validation #2879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add AML check to reject transactions where the user's name contains fewer than 4 letters. Banks require a minimum name length for processing. Changes: - Add AmlError.NAME_TOO_SHORT with CRUCIAL type and FAIL status - Add AmlReason.NAME_TOO_SHORT - Add countLetters() helper to count only alphabetic characters - Add name length validation in getAmlErrors() after NAME_MISSING check - Update SiftAmlDeclineMap and TransactionReasonMapper The check uses verifiedName, bankData.name, or completeName (in that order) and counts only letters (including European special characters like ä, ö, ü, ß).
🤖 PR Review Bot
|
davidleomay
reviewed
Jan 8, 2026
Comment on lines
41
to
43
| INTERMEDIARY_WITHOUT_SENDER = 'IntermediaryWithoutSender', | ||
| NAME_TOO_SHORT = 'NameTooShort', | ||
| } |
Member
There was a problem hiding this comment.
@Yannick1712 do we need to add mail texts when adding a new AmlReason?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
amlCheck: FAIL,amlReason: NameTooShortChanges
AmlError.NAME_TOO_SHORTwithCRUCIALtype andFAILstatusAmlReason.NAME_TOO_SHORTcountLetters()helper counting only alphabetic characters (incl. ä, ö, ü, ß, etc.)getAmlErrors()after existingNAME_MISSINGcheckSiftAmlDeclineMapandTransactionReasonMapperTest plan
amlCheck: FAILNameTooShortreason in admin panel