feat(bitcoin): accept unconfirmed withdrawals for faster buy payouts #2884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the confirmation requirement from checkTransferCompletion(). Previously, Bitcoin withdrawals from exchanges (e.g., Binance) had to wait for 1 blockchain confirmation before the liquidity pipeline could continue and trigger buy payouts. Now, as soon as the withdrawal TX is visible in the mempool, the pipeline completes and buy payouts can be created immediately. This works because: - getBalance() already includes untrusted_pending (unconfirmed external) - sendMany() already uses include_unsafe: true for coin selection - CPFP fee multiplier is active for unconfirmed UTXOs Expected improvement: Buy payouts can occur in the same block as the exchange withdrawal instead of the next block (~10-15 min faster).
🤖 PR Review Bot
|
davidleomay
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
checkTransferCompletion()for BitcoinWhy this works
All prerequisites are already in place:
getBalance()includesuntrusted_pending(unconfirmed external UTXOs)sendMany()usesinclude_unsafe: truefor coin selectionExpected improvement
~10-15 minutes faster buy payouts after exchange withdrawals.
Before: Withdrawal → wait for block → Pipeline Complete → next block → Payout
After: Withdrawal → Pipeline Complete → same block → Payout (CPFP effect)
Test plan
liquidity_management_ordercompletes immediately (before block confirmation)