Make includeTx parameter optional in receiveFor hooks #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
includeTxparameter tosell.hook.tsreceiveFor(default:false)includeTxparameter toswap.hook.tsreceiveFor(default:false)depositTxwhen explicitly needed (e.g., when user clicks send button)Problem
The API was attempting to create a deposit transaction even when the user is just viewing a price quote. This caused "insufficient funds for intrinsic transaction cost" errors when the wallet has insufficient gas for transaction estimation.
Solution
Make
includeTxan optional parameter that defaults tofalse. Consumers should passincludeTx=trueonly when they actually need the prepared transaction (i.e., when the user is ready to send).Usage
Test plan
includeTx=truestill returnsdepositTxwhen needed