Fix: Enable CI tests on develop-to-main PRs #820
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR workflow was configured to skip "Build and test" job when the source branch was develop. This meant PRs from develop to main never ran tests, defeating the purpose of CI validation before production. Now tests run on all PRs regardless of source branch.
Member
|
This condition is there because a push to develop triggers CI workflow which also executes tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
if: github.head_ref != 'develop'condition from PR workflowRoot Cause
if: github.head_ref != 'develop'be12683- when pr.yml was first createdThe condition was present from the start, likely copied from another workflow or a misunderstanding of the intended behavior.
Test plan