Fix EIP-7702 authorization nonce to use dynamic value #821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nonce was hardcoded to 0, which only works for accounts that have never sent a transaction. Now fetches the current nonce from the network using web3.eth.getTransactionCount(), ensuring EIP-7702 delegations work correctly for accounts with existing transaction history.
Collaborator
Author
|
Closing this PR - further investigation revealed that the entire EIP-7702 authorization signature method in the frontend is fundamentally broken (uses EIP-712 instead of proper EIP-7702 format). The nonce fix is irrelevant until we implement wallet_sendCalls + Paymaster approach. See analysis in plan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nonce: 0with dynamic nonce fromweb3.eth.getTransactionCount()Problem
The EIP-7702 authorization nonce was hardcoded to
0, which only works for:It fails for:
Solution
Fetch the current nonce from the network before signing the authorization.
Test plan