Add wallet_sendCalls with Paymaster for gasless transactions #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate EIP-7702 from manual signing to wallet_sendCalls (ERC-5792) with Paymaster. Changes: - Add sendCallsWithPaymaster() to metamask.hook.ts for ERC-5792 wallet_sendCalls - Add supportsWalletSendCalls() to check wallet capability - Update tx-helper.hook.ts to use Paymaster flow when usePaymaster flag is set - Update payment-info.tsx to check for Paymaster before legacy EIP-7702 flow The new flow: 1. Backend sets usePaymaster=true and paymasterUrl when user has 0 gas 2. Frontend calls wallet_sendCalls with paymasterService capability 3. MetaMask handles EIP-7702 internally and requests gas sponsorship from Paymaster 4. Transaction is sent without user needing any ETH
Includes usePaymaster and paymasterUrl fields in UnsignedTx interface
- supportsWalletSendCalls tests (8 tests): - Capability detection for atomicBatch - Error handling for unsupported wallets - sendCallsWithPaymaster tests (14 tests): - wallet_sendCalls with paymaster URL - Chain ID handling (Ethereum, Arbitrum, Base, Polygon) - Multiple calls in single transaction - Error scenarios (wrong network, no account) - Error code handling tests (3 tests)
Collaborator
Author
|
Closing: Frontend code is correct but requires working backend paymaster. Current backend implementation needs Pimlico integration. See analysis: docs/PIMLICO-PAYMASTER-ANALYSIS.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sendCallsWithPaymaster()tometamask.hook.tsfor ERC-5792wallet_sendCallssupportsWalletSendCalls()to check wallet capabilitytx-helper.hook.tsto use Paymaster flow whenusePaymasterflag is setpayment-info.tsxto check for Paymaster before legacy EIP-7702 flowContext
The original EIP-7702 implementation using manual
eth_signis broken because MetaMask disableseth_signby default. This PR migrates towallet_sendCalls(ERC-5792) with Paymaster sponsorship.New Flow
usePaymaster=trueandpaymasterUrlwhen user has 0 gaswallet_sendCallswithpaymasterServicecapabilityDependencies
Test plan