-
Notifications
You must be signed in to change notification settings - Fork 1
Update ichorCNA to the nf-core upstream versions #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This updates the samplesheet in preparation of DIncalciLab/samurai#57.
|
**BREAKING CHANGE**: this changes the format parameters for ichorCNA
|
Pushed a "defensive" change against ichorCNA's liberal handling of inputs. The downside is that some of the |
|
Not a blocker, but GavinHaLab/ichorCNA#26 wold be good to have (although that requires either a new ichorCNA version, or bioconda/bioconda-recipes#61045 to be merged) |
|
The bioconda PR has been merged, so I need to create a new container and push the update to nf-core. To speed things up we can use the patch functionality of nf-core to use the newer container ASAP. |
|
All good on my side. @SaraPotente please check if there are any blockers. I'll update the changelog in the mean time, then if all is well, merge and cut a new release. |
This PR updates the ichorCNA modules to their upstream versions and updates to the latest available version in nf-core (0.5.1).
Cf. #34
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).