Fix for Issue #2, SIGALRM error #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reviously, SIGALRM was used but this is only available on Python running UNIX.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated crnverifier.py to allow compatibility on Windows computers. Previously, SIGALRM was used but this is only available on Python running UNIX. Instead of using Python's signals for timing out, the program will instead create a thread with the
timer_func(var timeout)function to act as a timeout signal.This fixes Issue #2 and allows me to use the CLI feature on a Windows computer correctly now.
This also passed all
pytesttests.