-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade @angular-devkit/build-angular from 17.3.17 to 18.2.20 #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…nerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-HTTPPROXYMIDDLEWARE-9691389 - https://snyk.io/vuln/SNYK-JS-TMP-11501554 - https://snyk.io/vuln/SNYK-JS-WEBPACKDEVSERVER-10300775 - https://snyk.io/vuln/SNYK-JS-WEBPACKDEVSERVER-10300777 - https://snyk.io/vuln/SNYK-JS-INFLIGHT-6095116
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to enhance the security posture of the frontend application by updating the core Angular development dependency, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request from Snyk upgrades @angular-devkit/build-angular to a new major version (v18) to fix security vulnerabilities. However, this introduces a critical incompatibility, as most other Angular packages in your project are on version 17. Angular requires all its packages to be on the same major version. Furthermore, I've noticed that some other @angular packages like @angular/cli and @angular/common are on even higher, mismatched versions (v20 and v19 respectively). This suggests the project's dependencies are in an inconsistent state. My review comment on package.json details the immediate issue from this PR and recommends a holistic approach to managing your Angular dependencies to ensure a stable build.
| }, | ||
| "dependencies": { | ||
| "@angular-devkit/build-angular": "^17.3.16", | ||
| "@angular-devkit/build-angular": "^18.2.20", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This upgrade to a new major version (v18) of @angular-devkit/build-angular creates a version mismatch with the rest of the Angular framework packages (e.g., @angular/core), which are on v17.
Angular packages must be aligned on the same major version to avoid build failures and runtime errors. Mixing major versions is unsupported.
Recommendation:
Either perform a full migration of all @angular/* packages to v18 (using ng update), or reject this change and find an alternative fix for the vulnerabilities that is compatible with Angular 17 (e.g., using overrides in package.json). Merging this change as-is will likely break your application.
Snyk has created this PR to fix 5 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
frontend/package.jsonfrontend/package-lock.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-HTTPPROXYMIDDLEWARE-9691389
SNYK-JS-TMP-11501554
SNYK-JS-WEBPACKDEVSERVER-10300775
SNYK-JS-WEBPACKDEVSERVER-10300777
SNYK-JS-INFLIGHT-6095116
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.