[Snyk] Upgrade puppeteer-cluster from 0.23.0 to 0.24.0 #86
Conversation
Snyk has created this PR to upgrade puppeteer-cluster from 0.23.0 to 0.24.0. See this package in npm: puppeteer-cluster See this project in Snyk: https://app.snyk.io/org/apichanmittare/project/f2211921-2161-45bd-8fa7-81e0daf1e2fb?utm_source=github&utm_medium=referral&page=upgrade-pr
|
| Status | Scanner |  Critical |
 High |
 Medium |
 Low |
Total (0) |
|---|---|---|---|---|---|---|
| Open Source Security | 0 | 0 | 0 | 0 | See details |
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, focuses on maintaining the project's health and security by upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, initiated by Snyk to upgrade puppeteer-cluster, also includes several other significant dependency updates, such as major version bumps for typescript and @typescript-eslint/eslint-plugin. These major upgrades introduce considerable risks. I've identified a critical peer dependency conflict with @typescript-eslint/parser and a new, much stricter Node.js version requirement from @typescript-eslint/eslint-plugin. I've also highlighted the potential for breaking changes from the TypeScript v5 upgrade. Please review the detailed comments, as these issues could break your build and linting processes.
| }, | ||
| "devDependencies": { | ||
| "@typescript-eslint/eslint-plugin": "^5.30.5", | ||
| "@typescript-eslint/eslint-plugin": "^8.45.0", |
There was a problem hiding this comment.
This major upgrade of @typescript-eslint/eslint-plugin from v5 to v8 has two critical side-effects:
- Stricter Node.js requirement: v8 requires Node.js
^18.18.0 || ^20.9.0 || >=21.1.0. Please verify your environments support this. - Peer dependency conflict: This plugin now requires
@typescript-eslint/parserv8, but yourpackage.jsonhas v5. This will likely break your linting.
You should upgrade @typescript-eslint/parser to a compatible version (e.g., ^8.45.0) in package.json and update your lock file.
| "typescript": "~4.7.4" | ||
| "puppeteer": "^24.23.0", | ||
| "puppeteer-cluster": "^0.24.0", | ||
| "typescript": "~5.9.3" |
There was a problem hiding this comment.
This PR upgrades TypeScript from v4 to v5. This is a major version upgrade that may introduce breaking changes. Please carefully test that your project still compiles and runs as expected. For a detailed list of what has changed, you can refer to the TypeScript 5.0 announcement blog post.
Snyk has created this PR to upgrade puppeteer-cluster from 0.23.0 to 0.24.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 1 version ahead of your current version.
The recommended version was released 2 years ago.
Release notes
Package name: puppeteer-cluster
-
0.24.0 - 2024-03-17
- Updated all dependencies to their latest versions
- Added a missing timeout case when closing the browser
- Removed
- Dropped support (in tests) for Node.js <=16 as puppeteer also support for these versions
- Fixed breaking puppeteer changes introduced in version 22 (renamed
-
0.23.0 - 2022-01-23
- Updated dependencies which haven't been updated for more than one year
- Moved from Travis to Github Actions
- Remove the linter for now, but will probably add it back later after having a look at the pull requests.
- Fixed bug #395 not using
from puppeteer-cluster GitHub release notesNote: Use a version older than
0.24.0if you want to use a puppeteer version older than 22.0.0.Changed
package-lock.jsonas otherwise yarn complains (warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.).Fixed
createIncognitoBrowserContexttocreateBrowserContext)Changed
Fixed
perBrowserOptionsImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: