Skip to content

Conversation

@DashCoreAutoGuix
Copy link
Owner

Summary

Backports bitcoin#26294

This commit moves util/url.h and util/url.cpp to common/url.h and common/url.cpp as part of Bitcoin's library reorganization.

Changes:

  • Renamed src/util/url.{h,cpp} to src/common/url.{h,cpp}
  • Updated include paths in all affected source files
  • Updated src/Makefile.am to reflect new file locations
  • Added $(EVENT_CFLAGS) to libbitcoin_common_a_CPPFLAGS
  • Added $(LIBBITCOIN_COMMON) to dash_cli_LDADD

Dash-specific adaptations:

  • Skipped build_msvc/ files (not present in Dash)
  • Skipped ci/test/06_script_b.sh (not present in Dash)
  • Updated src/wallet/rpc/wallet.cpp (Dash-specific file that references url.h)
  • Preserved <stacktraces.h> include in src/bitcoind.cpp (Dash-specific)

Verification:

  • ✅ Build passed
  • ✅ Unit tests passed
  • ✅ Scope: 92% of Bitcoin changes (within 80-200% range)

Original commit: 27e76af

3a0b352 refactor: move url.h/cpp from lib util to lib common (fanquake)
058eb69 build: add missing event cflags to libbitcoin_util (fanquake)

Pull request description:

  Move `util/url` to `common/url`.

  Also add missing `event_*` flags to `libbitcoin_util`. bitcoin#26293 + the commit dropping boost cppflags from `libbitcoin_util` shows this issue. i.e:
  ```bash
    CXX      util/libbitcoin_util_a-url.o
  util/url.cpp:7:10: fatal error: 'event2/http.h' file not found
  #include <event2/http.h>
             ^~~~~~~~~~~~~~~
  1 error generated.
  ```

ACKs for top commit:
  hebasto:
    ACK 3a0b352
  ryanofsky:
    Code review ACK 3a0b352

Tree-SHA512: 600a76fd334267a02d332df9b67891a38d3fd7f5baf8a82b2447879b3bc65eab2552d2c081c0a5f1ec927bf80df7fc1f0cbbdda4cb76994b46dadf260b8e1cb3
@coderabbitai
Copy link

coderabbitai bot commented Dec 6, 2025

Warning

Rate limit exceeded

@DashCoreAutoGuix has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 11 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 9cf919c and 5e460cf.

📒 Files selected for processing (11)
  • src/Makefile.am (3 hunks)
  • src/bitcoin-cli.cpp (1 hunks)
  • src/bitcoin-wallet.cpp (1 hunks)
  • src/bitcoind.cpp (1 hunks)
  • src/common/url.cpp (1 hunks)
  • src/common/url.h (1 hunks)
  • src/qt/main.cpp (1 hunks)
  • src/test/fuzz/string.cpp (1 hunks)
  • src/test/util/setup_common.cpp (1 hunks)
  • src/wallet/rpc/util.cpp (1 hunks)
  • src/wallet/rpc/wallet.cpp (1 hunks)
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backport-0.25-batch-480-pr-26294

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants