Merge bitcoin/bitcoin#25986: test: refactor RPCPackagesTest to use MiniWallet
#1237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backport of bitcoin#25986
This PR refactors
RPCPackagesTestto useMiniWalletfor transaction creation, simplifying the test code and making it more maintainable.Changes:
RPCPackagesTestto useMiniWallet.create_self_transfer()andMiniWallet.create_self_transfer_multi()for transaction creationcreate_self_transfer_chain()method toMiniWalletclasssend_self_transfer_chain()method toMiniWalletclassmake_chain,create_child_with_parents, andcreate_raw_chainfunctions fromwallet.pyDash-specific adaptations:
wtxidreferences as Dash does not support SegWittest_rbfandtest_submitpackagetests as they depend on BIP125 RBF and package relay features not present in this versionOriginal Bitcoin PR: bitcoin#25986
Original commit:
00c323610aTest Plan
rpc_packages.pyfunctional test passesMiniWalletcontinue to work