Skip to content

Conversation

@DashCoreAutoGuix
Copy link
Owner

Summary

Backport of bitcoin#25986

This PR refactors RPCPackagesTest to use MiniWallet for transaction creation, simplifying the test code and making it more maintainable.

Changes:

  • Refactors RPCPackagesTest to use MiniWallet.create_self_transfer() and MiniWallet.create_self_transfer_multi() for transaction creation
  • Adds create_self_transfer_chain() method to MiniWallet class
  • Adds send_self_transfer_chain() method to MiniWallet class
  • Removes the no-longer-needed make_chain, create_child_with_parents, and create_raw_chain functions from wallet.py

Dash-specific adaptations:

  • Removed wtxid references as Dash does not support SegWit
  • Excluded test_rbf and test_submitpackage tests as they depend on BIP125 RBF and package relay features not present in this version

Original Bitcoin PR: bitcoin#25986
Original commit: 00c323610a

Test Plan

  • Build passes
  • rpc_packages.py functional test passes
  • Other functional tests using MiniWallet continue to work

…let`

Backport of bitcoin#25986

Original commit: 00c3236

Refactors RPCPackagesTest to use MiniWallet for transaction creation,
and adds create_self_transfer_chain method to MiniWallet class.
Removes the no-longer-needed make_chain, create_child_with_parents,
and create_raw_chain functions from wallet.py.

Note: Removed wtxid references as Dash does not support SegWit.
Also excluded test_rbf and test_submitpackage tests as they depend
on BIP125 RBF and package relay features.
@coderabbitai
Copy link

coderabbitai bot commented Dec 9, 2025

Warning

Rate limit exceeded

@DashCoreAutoGuix has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 26 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between e3d61f2 and 526785f.

📒 Files selected for processing (2)
  • test/functional/rpc_packages.py (5 hunks)
  • test/functional/test_framework/wallet.py (1 hunks)
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backport-0.25-batch-488-pr-25986

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants