Fuse key verification #140
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-iwanicki
force-pushed
the
fuse-key-verification
branch
5 times, most recently
from
4a286a7 to
a22ed0b
Compare
3mkusiak
requested changes
Dec 22, 2025
Contributor
3mkusiak
left a comment
3mkusiak
left a comment
There was a problem hiding this comment.
Two nitpicks, LGTM otherwise.
I still need to test it on qemu.
m-iwanicki
force-pushed
the
fuse-key-verification
branch
from
a42c68e to
32fcecd
Compare
3mkusiak
approved these changes
Dec 22, 2025
Contributor
3mkusiak
left a comment
3mkusiak
left a comment
There was a problem hiding this comment.
LGTM, verified in qemu.
Not merging since there are more reviewers assigned.
SergiiDmytruk
approved these changes
Dec 22, 2025
Member
SergiiDmytruk
left a comment
SergiiDmytruk
left a comment
There was a problem hiding this comment.
Bash doesn't allow using '-' in function names
It does, even in POSIX-compliance mode (bash --posix). Maybe you got the error from a fake bash of busybox or something. man bash:
When in posix mode, fname must be a valid shell name and may not be the name of one of the POSIX
special builtins. In default mode, a function name can be any unquoted shell word that does not contain $.
That way there won't be duplication which we might forgot to update. Before this change, sourcing "$DTS_ENV" in shell connected to via ssh wasn't possible as "$DTS_HAL" was empty, which resulted in ssh session ending. Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>
This is to allow using some functions in source `$DTS_FUNCTIONS` without entering dts-boot first e.g. board_config. Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>
* Add argument parsing * allow passing expected key hash and firmware file to check. * Add error checks * Download expected key hash from dts-configs repository instead of hardcoding Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>
Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>
Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>
Signed-off-by: Michał Iwanicki <michal.iwanicki@3mdeb.com>
m-iwanicki
force-pushed
the
fuse-key-verification
branch
from
443fc82 to
db6ad78
Compare
Contributor
Author
|
@SergiiDmytruk you are right, I checked again and got no error this time. Reverted. Not sure where I got this error from. I can reproduce it by entering |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual usage of
btg_key_validator. Error paths on QEMU:Hash not defined in
dts-configsFailed to read flash:
Failed to export key manifest:
Hashes don't match:
Happy path:
Usage:
Fuse workflow on QEMU (emulated NovaCustom) with correctly signed binary:
Fuse workflow on QEMU (emulated NovaCustom) with update binary signed with wrong key:
ref: zhs-397