-
Notifications
You must be signed in to change notification settings - Fork 46
Improve status reporting of e2e-test ci job. #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| image: registry.ddbuild.io/images/docker:20.10-py3 | ||
| tags: ["arch:amd64"] | ||
| script: | ||
| - git clone -b rey.abolofia/status-check --single-branch https://gitlab-ci-token:${CI_JOB_TOKEN}@gitlab.ddbuild.io/DataDog/serverless-e2e-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self:
Remove the branch specifier once the PR in serverless-e2e-tests repo is merged.
d37c266 to
bb19158
Compare
2eb31e2 to
b634b49
Compare
ci/input_files/build.yaml.tpl
Outdated
| else | ||
| echo "❓ Unknown E2E test status: $E2E_JOB_STATUS" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script has now been moved to the serverless-e2e-tests repo. This way we can use the same script from every repo we wish to trigger the e2e tests.
c5a44ec to
392c594
Compare
WIP Publishes to us-west-2. Fix needs and update things. Use underscore. No dot. Correct replace. Use variables. Properly get arn. Just Trim. Multiline string. Change to template comment. No more multiline. Remove comment? Combine lines again. Move comment. Another multiline. Exit if not found. Set -x. More debugging. Even more debugging. Broaden regex. Subscript. No more subscript. Artifacts true. Inherit dependencies and variables. Add testing downstream branch. Remove dependencies use variables. Use loop and main. Uncomment other tests. Cleanup version env vars. Whitespace cleanups. Only deploy layers on success. Add e2e-status check. Improve output of job. Needing publish loads dotenv artifact. Have e2e-status job start right away then poll. Comment out tests for now. Use apk. Debugging. Try JOB-TOKEN. Print out URL. Try bridges api. Try GITLAB_API_TOKEN. Use CI_JOB_STATUS to determine pass/fail. Remove switch. Create dotenv file from publish script. Use docker docker image. This needs not needed. Push check status to file in e2e repo. Start status checking in test stage. Remove e2e-test-status job for now. Improve test status reporting. Improve status reporting of e2e-test ci job.
b634b49 to
d1cf68a
Compare
|
closing in favor of https://github.com/DataDog/serverless-e2e-tests/pull/125 |
What does this PR do?
Adds new ci job. This will clone the
serverless-e2e-testsrepo and run a checker script. This script will find the running e2e test pipeline and exit 0 only when all of the test jobs have passed.Motivation
Right now, the e2e-tests ci job will only report success/failure when it is completely done. Meaning, it will also need to wait the 2 hours for the delayed cleanup jobs to run.
Also, the e2e-tests ci job doesn't appear in the github checks for quite a while. It won't run until all the integration and unit tests have run, and the testing layers have been pushed to aws. This is in the 45 minute range. It would be really nice to have it appear at the same time as the integration tests so people know as early as possible that it needs to run.
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply
datadoghq.atlassian.net/browse/APMSVLS-20