Skip to content

Conversation

@luxscious
Copy link
Contributor

@luxscious luxscious commented Nov 6, 2025

fix: add examples to the match pattern docs to further clarify the functionality of pattern matching.
test: add tests that correlate to the readMe example

@luxscious luxscious requested a review from a team as a code owner November 6, 2025 19:37
Copilot AI review requested due to automatic review settings November 6, 2025 19:37
@luxscious luxscious changed the title fix: update match patterns fix: update match patterns docs Nov 6, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates regular expression patterns used for code insights to capture a broader range of function call patterns. The previous patterns only matched string literals as the first argument, while the new patterns support any expression type (variables, objects, etc.) and properly handle a second parameter that can be either a simple value or an object.

Key Changes:

  • Updated regex patterns to match function calls with non-string-literal first arguments
  • Enhanced patterns to properly capture second parameters including object literals

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@luxscious luxscious requested a review from a team November 6, 2025 19:38
@luxscious luxscious marked this pull request as draft November 6, 2025 19:39
@luxscious luxscious force-pushed the fix-update-repo-config-match-patterns-docs branch from e737612 to d3928c5 Compare November 6, 2025 21:12
@luxscious luxscious force-pushed the fix-update-repo-config-match-patterns-docs branch from d3928c5 to d928a15 Compare November 6, 2025 21:15
@luxscious luxscious marked this pull request as ready for review November 6, 2025 21:16
Copilot AI review requested due to automatic review settings November 6, 2025 21:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@luxscious luxscious merged commit a1ca872 into main Nov 6, 2025
9 checks passed
@luxscious luxscious deleted the fix-update-repo-config-match-patterns-docs branch November 6, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants