fix: resolve TypeScript type inference error with MCP SDK 1.24.0 #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: JamieSinn <1538232+JamieSinn@users.noreply.github.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
devcycle-mcp-server | 1de22aa | Dec 03 2025, 05:43 PM |
Copilot
AI
changed the title
[WIP] Bump @modelcontextprotocol/sdk to version 1.24.0
fix: resolve TypeScript type inference error with MCP SDK 1.24.0
Dec 3, 2025
JamieSinn
reviewed
Dec 3, 2025
| const result = await handler(args) | ||
| this.server.registerTool( | ||
| name, | ||
| toolConfig as any, |
Member
There was a problem hiding this comment.
@jonathannorris this is the only material change here - any issue with this? It's resolving this error:
https://github.com/DevCycleHQ/cli/actions/runs/19902129668/job/57048640004?pr=548#step:7:6
There was a problem hiding this comment.
Pull request overview
This PR fixes a TypeScript compilation error introduced by the MCP SDK 1.24.x upgrade by adding an explicit type assertion to prevent excessively deep type inference.
- Adds
as anytype assertion totoolConfigparameter inregisterToolWithErrorHandling()to work around TypeScript's type inference depth limit - Reformats the
registerTool()call for better readability - Bumps version from 6.1.3 to 6.1.4
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/mcp/server.ts | Adds type assertion to toolConfig parameter and reformats registerTool() call to resolve TypeScript compilation error |
| oclif.manifest.json | Updates version from 6.1.3 to 6.1.4 reflecting the patch fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JamieSinn
merged commit 294d122
into
dependabot/npm_and_yarn/modelcontextprotocol/sdk-1.24.0
11 checks passed
JamieSinn
added a commit
that referenced
this pull request
Dec 3, 2025
* chore(deps): bump @modelcontextprotocol/sdk from 1.20.2 to 1.24.0 Bumps [@modelcontextprotocol/sdk](https://github.com/modelcontextprotocol/typescript-sdk) from 1.20.2 to 1.24.0. - [Release notes](https://github.com/modelcontextprotocol/typescript-sdk/releases) - [Commits](modelcontextprotocol/typescript-sdk@1.20.2...1.24.0) --- updated-dependencies: - dependency-name: "@modelcontextprotocol/sdk" dependency-version: 1.24.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * fix: resolve TypeScript type inference error with MCP SDK 1.24.0 (#549) * Initial plan * fix: resolve TypeScript type inference error with MCP SDK 1.24.0 Co-authored-by: JamieSinn <1538232+JamieSinn@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JamieSinn <1538232+JamieSinn@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: JamieSinn <1538232+JamieSinn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade to
@modelcontextprotocol/sdk1.24.0 introduced stricter type inference inregisterTool(), causing TypeScript to fail with "Type instantiation is excessively deep and possibly infinite" at build time.Changes
toolConfigparameter inregisterToolWithErrorHandling()to prevent overly complex type inferenceThis preserves runtime type safety through Zod schema validation while avoiding TypeScript's type inference limits.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.