Remove type annotations from enum types #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are flagged as an error by pyright as they fields have to be instances of the class.
tpoliaw
force-pushed
the
enum_type_annotations
branch
from
ea3581a to
4c73086
Compare
abbiemery
reviewed
Jul 25, 2023
Collaborator
abbiemery
left a comment
abbiemery
left a comment
There was a problem hiding this comment.
The eiger might use these for magic, so I'd refer this to @callumforrester before just removing them.
DiamondJoseph
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are flagged as an error by pyright as they fields have to be
instances of the class.