-
Notifications
You must be signed in to change notification settings - Fork 42
Improve project structure and build system #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm sorry, I don't know if I can accept this PR currently. This PR is a significant change and we haven't discussed any of these specific changes in the Discord server. |
|
I believe it should be extremely clear which parts are meant to be cross-platform (specifically |
iProgramMC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this PR isn't that bad. but I would've appreciated a heads-up discussion before you went through with it.
Also please move src/discord/Frontend.hpp to src/core/Frontend.hpp so we can have just one directory again (src/core)
|
@iProgramMC are the changes good now? |
|
Other than these comments everything else looks good. |
|
BTW, I have actually been thinking to do a two-way merge with my Purplecord project in order to create a new library that both DiscordMessenger and Purplecord to use. But this is for later. |
The UI is platform specific. There will be no abstractions over the platform to create a cross-platform interface. |
|
Can you please rebase with master to fix the "entire file changed" shenanigans? Turns out they were caused by line endings that weren't normalized to LF. |
|
What the... this is weird. |
|
wtf |
|
211.diff.txt |
What I have done here is to:
Nothing about the functionality has changed in this PR (unless you include the Makefile), it's mostly laying the groundwork for a better organization so it's easier for me to later abstract for different platforms and GUI toolkits.
Sidenote: I am not exactly sure where to place the Frontend.hpp, which is why it's currently sitting awkwardly in src/discord. Perhaps a src/ui would make more sense, with some abstractions for buttons, text areas etc.