Skip to content

Conversation

@pascalecu
Copy link
Contributor

What I have done here is to:

  • move the src/discord files around into a more logical structure
  • added corresponding filters in VS, as well as filters for the Windows dir (I didn't feel the need to reorder the files there, since I am not touching that part of the source code)
  • improve Makefile by cleaning it up
  • use the latest available target platform instead of hardcoding W11 22H2

Nothing about the functionality has changed in this PR (unless you include the Makefile), it's mostly laying the groundwork for a better organization so it's easier for me to later abstract for different platforms and GUI toolkits.

Sidenote: I am not exactly sure where to place the Frontend.hpp, which is why it's currently sitting awkwardly in src/discord. Perhaps a src/ui would make more sense, with some abstractions for buttons, text areas etc.

@iProgramMC
Copy link
Contributor

I'm sorry, I don't know if I can accept this PR currently. This PR is a significant change and we haven't discussed any of these specific changes in the Discord server.

@iProgramMC
Copy link
Contributor

iProgramMC commented Sep 29, 2025

Especially I disagree with the dismantling of src/discord. (src/discord looks to have been mostly just moved into src/core, at first glance I thought this PR would split it into multiple directories)

I believe it should be extremely clear which parts are meant to be cross-platform (specifically src/discord) and which are not (specifically src/windows)

Copy link
Contributor

@iProgramMC iProgramMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this PR isn't that bad. but I would've appreciated a heads-up discussion before you went through with it.

Also please move src/discord/Frontend.hpp to src/core/Frontend.hpp so we can have just one directory again (src/core)

@iProgramMC iProgramMC added the enhancement New feature or request label Sep 29, 2025
@pascalecu
Copy link
Contributor Author

@iProgramMC are the changes good now?

@iProgramMC
Copy link
Contributor

Other than these comments everything else looks good.

@iProgramMC
Copy link
Contributor

BTW, I have actually been thinking to do a two-way merge with my Purplecord project in order to create a new library that both DiscordMessenger and Purplecord to use. But this is for later.

@iProgramMC
Copy link
Contributor

Perhaps a src/ui would make more sense, with some abstractions for buttons, text areas etc.

The UI is platform specific. There will be no abstractions over the platform to create a cross-platform interface.

@iProgramMC
Copy link
Contributor

Can you please rebase with master to fix the "entire file changed" shenanigans? Turns out they were caused by line endings that weren't normalized to LF.

@pascalecu
Copy link
Contributor Author

What the... this is weird.

@iProgramMC
Copy link
Contributor

wtf

@iProgramMC
Copy link
Contributor

211.diff.txt
I saved the diff if you can't figure out how to recover your changes from git reflog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants