[WIP] Implement Tree proposal with Dice #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navjotk
force-pushed
the
attempt_refactor_proposal
branch
from
11da6ad to
3858d57
Compare
| self.cmf = np.cumsum(probabilities) | ||
| self.randomiser = Random() | ||
|
|
||
| def eval(self): |
Collaborator
There was a problem hiding this comment.
I think this function should be named "sample", rather than "eval" to match what's implemented in types.py
Collaborator
|
This looks a step in the right direction - thanks for figuring out a sensible way to articulate it in code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not complete yet but posting to request for comment. Moves in the direction fixing #10