Skip to content

Conversation

@yhaddad
Copy link

@yhaddad yhaddad commented Jun 12, 2017

Porting of ECALELF to CMSSW 92x. The code was successfully tested on CMSSW_9_2_0_patch5 and CMSSW_9_2_1. Follow the instruction on the README for the installation.

@yhaddad yhaddad requested review from previsualconsent and removed request for previsualconsent June 12, 2017 10:12
Copy link

@shervin86 shervin86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems everything ok to me.
Can you please check to have used astyle to format the code?
you can use this script /afs/cern.ch/user/s/shervin/public/formatCode.sh
formatCode.sh interface/* src/* etc.

@yhaddad
Copy link
Author

yhaddad commented Jun 13, 2017

@shervin86 Thanks for the helpful script.

Copy link

@shervin86 shervin86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if this works also on 8_0_26 or 24

@yhaddad
Copy link
Author

yhaddad commented Jun 16, 2017

I successfully checked the compatibility on CMSSW_8_0_24_patch1 and CMSSW_8_0_28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants