Add boost header include for specializing boost::hash #213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
include/fc/crypto/sha256.hppwe specializedboost::hash<>without properly including the Boost header<boost/container_hash/hash.hpp>.fc/include/fc/crypto/sha256.hpp
Lines 125 to 130 in 0793fbe
This PR includes the above header.
The previous success of the fc build might have relied on some cross-inclusion among the Boost headers. However, while this is still okay with Boost
1.76, the fc library build starts to fail with the latest Boost1.77version (built on a Ubuntu 18.04 machine with g++-8) reporting the following errors:Considering that the current EOSIO software mostly depends on Boost
1.72, it is still okay for the fc library for the time being. But the problem might surface if we will upgrade to1.77or later.