Skip to content

Conversation

@mo-hlawrence
Copy link
Contributor

In response to a comment on PR#111, this is to update the units for the number fraction variables for GLOMAP dust. The units are changed to particles molecules-1 since the variable describes the number of particles of dust per number of molecules of air. I've also updated the description of the variables to make it more precise - following the documentation from GLOMAP/UKCA.

@mo-hlawrence
Copy link
Contributor Author

@jeromebarre I don't seem to have permission to add you as reviewer myself. Please could you check if this change is ok for you?

Copy link

@jeromebarre jeromebarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes kind of a strange long names but at least it's now clear what those variables are.

@mo-hlawrence
Copy link
Contributor Author

This makes kind of a strange long names but at least it's now clear what those variables are.

I know - if you prefer I can change the description back to what it was since other variables tend to have much shorter names.

Copy link
Collaborator

@gold2718 gold2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay.

@mkavulich
Copy link
Collaborator

Just making sure I understand correctly: these quantities are a ratio of the number of aerosol particles to the number of air molecules in a given volume? If that's correct, I would suggest that as a more clear "long_name" description.

@mo-hlawrence
Copy link
Contributor Author

Just making sure I understand correctly: these quantities are a ratio of the number of aerosol particles to the number of air molecules in a given volume? If that's correct, I would suggest that as a more clear "long_name" description.

Yes I think that's right. I've been told it's "the ratio of the particle number concentration to the molecular concentration of air."

Copy link
Collaborator

@mkavulich mkavulich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mo-hlawrence Can I suggest this addition for clarification in the long name field? Since this is for description/human-readability purposes and won't appear in source code, there shouldn't be any technical issue with large entries here.

<standard_name name="number_fraction_of_coarse_aerosol_particles_in_air"
long_name="Number fraction of coarse mode dust aerosol particles">
<type kind="kind_phys" units="1">real</type>
long_name="Ratio of number concentration of coarse mode dust aerosol particles to the molecular concentration of air">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
long_name="Ratio of number concentration of coarse mode dust aerosol particles to the molecular concentration of air">
long_name="Ratio of number concentration of coarse-mode dust aerosol particles to the molecular concentration of air; i.e., the ratio of the number of coarse-mode dust aerosol particles to the number of air molecules in a unit volume">

<standard_name name="number_fraction_of_accumulation_aerosol_particles_in_air"
long_name="Number fraction of accumulation mode dust aerosol particles">
<type kind="kind_phys" units="1">real</type>
long_name="Ratio of number concentration of accumulation mode dust aerosol particles to the molecular concentration of air">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
long_name="Ratio of number concentration of accumulation mode dust aerosol particles to the molecular concentration of air">
long_name="Ratio of number concentration of accumulation-mode dust aerosol particles to the molecular concentration of air; i.e., the ratio of the number of accumulation-mode dust aerosol particles to the number of air molecules in a unit volume">

Comment on lines +458 to +460
* `number_fraction_of_coarse_aerosol_particles_in_air`: Ratio of number concentration of coarse mode dust aerosol particles to the molecular concentration of air
* `real(kind=kind_phys)`: units = particles molecules-1
* `number_fraction_of_accumulation_aerosol_particles_in_air`: Ratio of number concentration of accumulation mode dust aerosol particles to the molecular concentration of air
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `number_fraction_of_coarse_aerosol_particles_in_air`: Ratio of number concentration of coarse mode dust aerosol particles to the molecular concentration of air
* `real(kind=kind_phys)`: units = particles molecules-1
* `number_fraction_of_accumulation_aerosol_particles_in_air`: Ratio of number concentration of accumulation mode dust aerosol particles to the molecular concentration of air
* `number_fraction_of_coarse_aerosol_particles_in_air`: Ratio of number concentration of coarse-mode dust aerosol particles to the molecular concentration of air; i.e., the ratio of the number of coarse-mode dust aerosol particles to the number of air molecules in a unit volume
* `real(kind=kind_phys)`: units = particles molecules-1
* `number_fraction_of_accumulation_aerosol_particles_in_air`: Ratio of number concentration of accumulation-mode dust aerosol particles to the molecular concentration of air; i.e., the ratio of the number of accumulation-mode dust aerosol particles to the number of air molecules in a unit volume

@mkavulich
Copy link
Collaborator

@mo-hlawrence Just checking on the status of this. If you're opposed to the suggested changes I wouldn't say they're required, but I'd be interested to hear the reasoning.

@mkavulich
Copy link
Collaborator

Since we still haven't heard from @mo-hlawrence, I will go ahead and merge this PR and open a new PR including the requested long_name changes.

@mkavulich mkavulich merged commit 7825994 into ESCOMP:main Oct 22, 2025
3 checks passed
mkavulich added a commit to mkavulich/ESMStandardNames that referenced this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants